Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 1897123002: Remove current implementation of frame timing events. (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
haibinlu, esprehn, vmpstr
CC:
anandc+watch-blimp_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, dshwang, dtrainor+watch-blimp_chromium.org, eae+blinkwatch, igrigorik, jam, jbauman+watch_chromium.org, jchaffraix+rendering, jessicag+watch-blimp_chromium.org, kalyank, kinuko+watch, kmarshall+watch-blimp_chromium.org, leviw+renderwatch, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, MikeB, nyquist+watch-blimp_chromium.org, pdr+renderingwatchlist_chromium.org, piman, piman+watch_chromium.org, rwlbuis, sievers+watch_chromium.org, sof, site-isolation-reviews_chromium.org, slimming-paint-reviews_chromium.org, sriramsr+watch-blimp_chromium.org, szager+layoutwatch_chromium.org, Ian Vollick, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove current implementation of frame timing events. The new draft [1] is significantly simpler and may not need frame IDs at all. Per feedback from igrigorik@, it's probably easier to just revert the current implementation until someone is ready to pick this up and work on it again. BUG=537864 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=haibinlu@chromium.org R=esprehn@chromium.org,vmpstr@chromium.org Committed: https://crrev.com/27d40dd253b7d2b51588c2322b75b32e185632cc Cr-Commit-Position: refs/heads/master@{#388313}

Patch Set 1 #

Patch Set 2 : Clean up stray android ref #

Patch Set 3 : Fix cc test #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1542 lines) Patch
M blimp/client/feature/compositor/blimp_compositor.h View 1 chunk +0 lines, -5 lines 0 comments Download
M blimp/client/feature/compositor/blimp_compositor.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M cc/BUILD.gn View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M cc/blink/web_layer_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/blink/web_layer_impl.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M cc/cc.gyp View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M cc/cc_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D cc/debug/frame_timing_request.h View 1 chunk +0 lines, -41 lines 0 comments Download
D cc/debug/frame_timing_request.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D cc/debug/frame_timing_tracker.h View 1 chunk +0 lines, -98 lines 0 comments Download
D cc/debug/frame_timing_tracker.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D cc/debug/frame_timing_tracker_unittest.cc View 1 chunk +0 lines, -297 lines 0 comments Download
M cc/layers/layer.h View 3 chunks +0 lines, -12 lines 0 comments Download
M cc/layers/layer.cc View 4 chunks +1 line, -19 lines 0 comments Download
M cc/layers/layer_impl.h View 1 2 3 3 chunks +0 lines, -10 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 2 3 4 chunks +0 lines, -29 lines 0 comments Download
M cc/test/fake_channel_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/test/fake_layer_tree_host_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl_client.h View 2 chunks +0 lines, -5 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M cc/test/proxy_impl_for_test.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/test/proxy_main_for_test.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/test/proxy_main_for_test.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M cc/trees/channel_impl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_client.h View 2 chunks +0 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 3 6 chunks +0 lines, -32 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 4 chunks +0 lines, -37 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 1 chunk +0 lines, -88 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_remote_server.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 3 1 chunk +0 lines, -16 lines 0 comments Download
M cc/trees/proxy_impl.h View 1 2 3 2 chunks +0 lines, -9 lines 0 comments Download
M cc/trees/proxy_impl.cc View 1 2 3 4 chunks +0 lines, -24 lines 0 comments Download
M cc/trees/proxy_main.h View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M cc/trees/proxy_main.cc View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M cc/trees/remote_channel_impl.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/remote_channel_impl.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M cc/trees/remote_channel_unittest.cc View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M cc/trees/threaded_channel.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/threaded_channel.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor_delegate.h View 2 chunks +0 lines, -9 lines 0 comments Download
M content/renderer/render_widget.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 1 chunk +0 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentTest.cpp View 1 chunk +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 1 2 3 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 3 chunks +0 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 3 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 chunk +0 lines, -243 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/public/platform/WebFrameTimingEvent.h View 1 chunk +0 lines, -42 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebWidget.h View 2 chunks +0 lines, -9 lines 0 comments Download
M ui/compositor/compositor.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
dcheng
+vmpstr for cc changes +esprehn for third_party/WebKit changes
4 years, 8 months ago (2016-04-19 00:14:02 UTC) #3
esprehn
lgtm
4 years, 8 months ago (2016-04-19 00:21:03 UTC) #4
vmpstr
This is awesome, lgtm. Thanks!
4 years, 8 months ago (2016-04-19 00:24:47 UTC) #5
dcheng
+vmpstr, mind confirming the test updates to remote_channel_unittest.cc? I trimmed a few more lines of ...
4 years, 8 months ago (2016-04-19 03:42:58 UTC) #6
vmpstr
still lgtm
4 years, 8 months ago (2016-04-19 18:05:36 UTC) #7
dcheng
TBRing //blimp OWNERS for simple code removal.
4 years, 8 months ago (2016-04-19 19:42:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897123002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897123002/60001
4 years, 8 months ago (2016-04-19 19:43:05 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-19 21:21:13 UTC) #15
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/27d40dd253b7d2b51588c2322b75b32e185632cc Cr-Commit-Position: refs/heads/master@{#388313}
4 years, 8 months ago (2016-04-22 19:16:32 UTC) #17
haibinlu
4 years, 8 months ago (2016-04-25 17:29:49 UTC) #18
Message was sent while issue was closed.
lgtm for blimp/ code

Powered by Google App Engine
This is Rietveld 408576698