Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2106)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 1897123002: Remove current implementation of frame timing events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host_impl.h ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index 03004e1e01ce05195352a7d79bc7d883a3f797b7..696f96cd63187c335b19d06b760494f3faa7958e 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -240,7 +240,6 @@ LayerTreeHostImpl::LayerTreeHostImpl(
id_(id),
requires_high_res_to_draw_(false),
is_likely_to_require_a_draw_(false),
- frame_timing_tracker_(FrameTimingTracker::Create(this)),
mutator_(nullptr) {
animation_host_ = AnimationHost::Create(ThreadInstance::IMPL);
animation_host_->SetMutatorHostClient(this);
@@ -900,16 +899,6 @@ DrawResult LayerTreeHostImpl::CalculateRenderPasses(
frame->will_draw_layers.push_back(*it);
it->AppendQuads(target_render_pass, &append_quads_data);
-
- // For layers that represent themselves, add composite frame timing
- // requests if the visible rect intersects the requested rect.
- for (const auto& request : it->frame_timing_requests()) {
- if (request.rect().Intersects(it->visible_layer_rect())) {
- frame->composite_events.push_back(
- FrameTimingTracker::FrameAndRectIds(
- active_tree_->source_frame_number(), request.id()));
- }
- }
}
++layers_drawn;
@@ -1611,11 +1600,6 @@ void LayerTreeHostImpl::DrawLayers(FrameData* frame) {
base::TimeTicks frame_begin_time = CurrentBeginFrameArgs().frame_time;
DCHECK(CanDraw());
- if (!frame->composite_events.empty()) {
- frame_timing_tracker_->SaveTimeStamps(frame_begin_time,
- frame->composite_events);
- }
-
if (frame->has_no_damage) {
TRACE_EVENT_INSTANT0("cc", "EarlyOut_NoDamage", TRACE_EVENT_SCOPE_THREAD);
DCHECK(!resourceless_software_draw_);
@@ -2250,27 +2234,6 @@ void LayerTreeHostImpl::CreateResourceAndTileTaskWorkerPool(
settings_.renderer_settings.preferred_tile_format);
}
-void LayerTreeHostImpl::RecordMainFrameTiming(
- const BeginFrameArgs& start_of_main_frame_args,
- const BeginFrameArgs& expected_next_main_frame_args) {
- std::vector<int64_t> request_ids;
- active_tree_->GatherFrameTimingRequestIds(&request_ids);
- if (request_ids.empty())
- return;
-
- base::TimeTicks start_time = start_of_main_frame_args.frame_time;
- base::TimeTicks end_time = expected_next_main_frame_args.frame_time;
- frame_timing_tracker_->SaveMainFrameTimeStamps(
- request_ids, start_time, end_time, active_tree_->source_frame_number());
-}
-
-void LayerTreeHostImpl::PostFrameTimingEvents(
- std::unique_ptr<FrameTimingTracker::CompositeTimingSet> composite_events,
- std::unique_ptr<FrameTimingTracker::MainFrameTimingSet> main_frame_events) {
- client_->PostFrameTimingEventsOnImplThread(std::move(composite_events),
- std::move(main_frame_events));
-}
-
void LayerTreeHostImpl::SetLayerTreeMutator(LayerTreeMutator* mutator) {
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("compositor-worker"),
"LayerTreeHostImpl::SetLayerTreeMutator");
« no previous file with comments | « cc/trees/layer_tree_host_impl.h ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698