Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1954)

Unified Diff: cc/layers/layer.cc

Issue 1897123002: Remove current implementation of frame timing events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/layer.h ('k') | cc/layers/layer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/layer.cc
diff --git a/cc/layers/layer.cc b/cc/layers/layer.cc
index 52f0d8a8f676b8068120612d5da35b918389596e..f9a8f2b9c7103dc16e23a0b78838943237a27143 100644
--- a/cc/layers/layer.cc
+++ b/cc/layers/layer.cc
@@ -90,8 +90,7 @@ Layer::Layer()
clip_parent_(nullptr),
replica_layer_(nullptr),
client_(nullptr),
- num_unclipped_descendants_(0),
- frame_timing_requests_dirty_(false) {}
+ num_unclipped_descendants_(0) {}
Layer::~Layer() {
// Our parent should be holding a reference to us so there should be no
@@ -1270,11 +1269,6 @@ void Layer::PushPropertiesTo(LayerImpl* layer) {
update_rect_.Union(layer->update_rect());
layer->SetUpdateRect(update_rect_);
- if (frame_timing_requests_dirty_) {
- layer->SetFrameTimingRequests(frame_timing_requests_);
- frame_timing_requests_dirty_ = false;
- }
-
// Reset any state that should be cleared for the next update.
subtree_property_changed_ = false;
update_rect_ = gfx::Rect();
@@ -1476,8 +1470,6 @@ void Layer::LayerSpecificPropertiesToProto(proto::LayerProperties* proto) {
// TODO(nyquist): Figure out what to do with LayerAnimationController.
// See crbug.com/570376.
- // TODO(nyquist): Figure out what to do with FrameTimingRequests. See
- // crbug.com/570377.
update_rect_ = gfx::Rect();
}
@@ -1793,16 +1785,6 @@ void Layer::RunMicroBenchmark(MicroBenchmark* benchmark) {
benchmark->RunOnLayer(this);
}
-void Layer::SetFrameTimingRequests(
- const std::vector<FrameTimingRequest>& requests) {
- // TODO(vmpstr): Early out if there are no changes earlier in the call stack.
- if (requests == frame_timing_requests_)
- return;
- frame_timing_requests_ = requests;
- frame_timing_requests_dirty_ = true;
- SetNeedsCommit();
-}
-
void Layer::SetElementId(uint64_t id) {
DCHECK(IsPropertyChangeAllowed());
if (element_id_ == id)
« no previous file with comments | « cc/layers/layer.h ('k') | cc/layers/layer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698