Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: cc/layers/layer_impl.cc

Issue 1897123002: Remove current implementation of frame timing events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/layer_impl.h ('k') | cc/test/fake_channel_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/layer_impl.cc
diff --git a/cc/layers/layer_impl.cc b/cc/layers/layer_impl.cc
index cc41ff717f6c707d264d15d50d44792f8dcfd21a..b7c0c1fd6018d51937571a8b0541ba37729f8065 100644
--- a/cc/layers/layer_impl.cc
+++ b/cc/layers/layer_impl.cc
@@ -91,7 +91,6 @@ LayerImpl::LayerImpl(LayerTreeImpl* tree_impl, int id)
mutable_properties_(MutableProperty::kNone),
debug_info_(nullptr),
force_render_surface_(false),
- frame_timing_requests_dirty_(false),
scrolls_drawn_descendant_(false),
layer_or_descendant_has_touch_handler_(false) {
DCHECK_GT(layer_id_, 0);
@@ -595,11 +594,6 @@ void LayerImpl::PushPropertiesTo(LayerImpl* layer) {
if (owned_debug_info_)
layer->SetDebugInfo(std::move(owned_debug_info_));
- if (frame_timing_requests_dirty_) {
- layer->SetFrameTimingRequests(frame_timing_requests_);
- frame_timing_requests_dirty_ = false;
- }
-
// Reset any state that should be cleared for the next update.
layer_property_changed_ = false;
update_rect_ = gfx::Rect();
@@ -1214,18 +1208,6 @@ void LayerImpl::Set3dSortingContextId(int id) {
sorting_context_id_ = id;
}
-void LayerImpl::SetFrameTimingRequests(
- const std::vector<FrameTimingRequest>& requests) {
- frame_timing_requests_ = requests;
- frame_timing_requests_dirty_ = true;
- SetNeedsPushProperties();
-}
-
-void LayerImpl::GatherFrameTimingRequestIds(std::vector<int64_t>* request_ids) {
- for (const auto& request : frame_timing_requests_)
- request_ids->push_back(request.id());
-}
-
void LayerImpl::SetTransform(const gfx::Transform& transform) {
if (transform_ == transform)
return;
@@ -1487,17 +1469,6 @@ void LayerImpl::AsValueInto(base::trace_event::TracedValue* state) const {
NOTREACHED();
}
}
-
- if (!frame_timing_requests_.empty()) {
- state->BeginArray("frame_timing_requests");
- for (const auto& request : frame_timing_requests_) {
- state->BeginDictionary();
- state->SetInteger("request_id", request.id());
- MathUtil::AddToTracedValue("request_rect", request.rect(), state);
- state->EndDictionary();
- }
- state->EndArray();
- }
}
bool LayerImpl::IsDrawnRenderSurfaceLayerListMember() const {
« no previous file with comments | « cc/layers/layer_impl.h ('k') | cc/test/fake_channel_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698