Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1895303007: Non passive touch end or touch cancel listeners should not block scroll. (Closed)

Created:
4 years, 8 months ago by dtapuska
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Non passive touch end or touch cancel listeners should not block scroll. Ensure that touch end or touch cancel listeners don't block scroll by removing these listeners from the touch hit test regions. When no touch listener is encountered for TouchStart examine the touch end/cancel listeners and determine if the touch start needs to be dispatched non-blocking. BUG=601990 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1884863003 Cr-Commit-Position: refs/heads/master@{#387399} (cherry picked from commit e1504c1965e9ee3f757bda6f8b357781b66fbf22) Committed: https://chromium.googlesource.com/chromium/src/+/6cf24acafd8d428d56d724bbf6f4f0a460973bec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+489 lines, -260 lines) Patch
M cc/input/event_listener_properties.h View 1 chunk +9 lines, -1 line 0 comments Download
M cc/proto/layer_tree_host.proto View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 3 chunks +18 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/non_blocking_event_browsertest.cc View 4 chunks +36 lines, -4 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/event-listener-on-attribute-inside-shadow-dom.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/event-listener-on-attribute-inside-shadow-dom-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/resources/compositor-touch-hit-rects.js View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/touch-action-touch-handlers.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/touch-handler-count.html View 7 chunks +118 lines, -77 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/touch-handler-count-expected.txt View 1 chunk +115 lines, -74 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/touch-input-element-change-documents.html View 1 chunk +9 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt View 1 chunk +9 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/touch-target-removed-crash.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/plugins/re-request-touch-events-crash.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/plugins/re-request-touch-events-crash-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp View 4 chunks +17 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 2 chunks +11 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 2 chunks +11 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebEventListenerProperties.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 2 chunks +12 lines, -1 line 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 3 chunks +42 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
4 years, 8 months ago (2016-04-20 18:28:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6cf24acafd8d428d56d724bbf6f4f0a460973bec.

Powered by Google App Engine
This is Rietveld 408576698