Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Side by Side Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 1895303007: Non passive touch end or touch cancel listeners should not block scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 751 matching lines...) Expand 10 before | Expand all | Expand 10 after
762 if (subFrame->isLocalFrame()) 762 if (subFrame->isLocalFrame())
763 shouldHandleScrollGestureOnMainThreadRegion.unite(computeShouldHandl eScrollGestureOnMainThreadRegion(toLocalFrame(subFrame), offset)); 763 shouldHandleScrollGestureOnMainThreadRegion.unite(computeShouldHandl eScrollGestureOnMainThreadRegion(toLocalFrame(subFrame), offset));
764 } 764 }
765 765
766 return shouldHandleScrollGestureOnMainThreadRegion; 766 return shouldHandleScrollGestureOnMainThreadRegion;
767 } 767 }
768 768
769 static void accumulateDocumentTouchEventTargetRects(LayerHitTestRects& rects, co nst Document* document) 769 static void accumulateDocumentTouchEventTargetRects(LayerHitTestRects& rects, co nst Document* document)
770 { 770 {
771 ASSERT(document); 771 ASSERT(document);
772 const EventTargetSet* targets = document->frameHost()->eventHandlerRegistry( ).eventHandlerTargets(EventHandlerRegistry::TouchEventBlocking); 772 const EventTargetSet* targets = document->frameHost()->eventHandlerRegistry( ).eventHandlerTargets(EventHandlerRegistry::TouchStartOrMoveEventBlocking);
773 if (!targets) 773 if (!targets)
774 return; 774 return;
775 775
776 // If there's a handler on the window, document, html or body element (fairl y common in practice), 776 // If there's a handler on the window, document, html or body element (fairl y common in practice),
777 // then we can quickly mark the entire document and skip looking at any othe r handlers. 777 // then we can quickly mark the entire document and skip looking at any othe r handlers.
778 // Note that technically a handler on the body doesn't cover the whole docum ent, but it's 778 // Note that technically a handler on the body doesn't cover the whole docum ent, but it's
779 // reasonable to be conservative and report the whole document anyway. 779 // reasonable to be conservative and report the whole document anyway.
780 // 780 //
781 // Fullscreen HTML5 video when OverlayFullscreenVideo is enabled is implemen ted by replacing the 781 // Fullscreen HTML5 video when OverlayFullscreenVideo is enabled is implemen ted by replacing the
782 // root cc::layer with the video layer so doing this optimization causes the compositor to think 782 // root cc::layer with the video layer so doing this optimization causes the compositor to think
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
1033 bool frameIsScrollable = frameView && frameView->isScrollable(); 1033 bool frameIsScrollable = frameView && frameView->isScrollable();
1034 if (frameIsScrollable != m_wasFrameScrollable) 1034 if (frameIsScrollable != m_wasFrameScrollable)
1035 return true; 1035 return true;
1036 1036
1037 if (WebLayer* scrollLayer = frameView ? toWebLayer(frameView->layerForScroll ing()) : nullptr) 1037 if (WebLayer* scrollLayer = frameView ? toWebLayer(frameView->layerForScroll ing()) : nullptr)
1038 return WebSize(frameView->contentsSize()) != scrollLayer->bounds(); 1038 return WebSize(frameView->contentsSize()) != scrollLayer->bounds();
1039 return false; 1039 return false;
1040 } 1040 }
1041 1041
1042 } // namespace blink 1042 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/page/ChromeClient.h ('k') | third_party/WebKit/Source/core/testing/Internals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698