third_party/WebKit/Source/core/html/HTMLInputElement.cpp - Issue 1895303007: Non passive touch end or touch cancel listeners should not block scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 1895303007: Non passive touch end or touch cancel listeners should not block scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp ('k') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

index f756cd497958287b3e5296d753c4eaa68457c453..914b449d301f4de3c51f555732dac78b4fbb705a 100644

--- a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

@@ -436,9 +436,9 @@ void HTMLInputElement::updateTouchEventHandlerRegistry()

EventHandlerRegistry& registry = document().frameHost()->eventHandlerRegistry();

// TODO(dtapuska): Make this passive touch listener see crbug.com/584438

if (hasTouchEventHandler)

- registry.didAddEventHandler(*this, EventHandlerRegistry::TouchEventBlocking);

+ registry.didAddEventHandler(*this, EventHandlerRegistry::TouchStartOrMoveEventBlocking);

else

- registry.didRemoveEventHandler(*this, EventHandlerRegistry::TouchEventBlocking);

+ registry.didRemoveEventHandler(*this, EventHandlerRegistry::TouchStartOrMoveEventBlocking);

m_hasTouchEventHandler = hasTouchEventHandler;

}