Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 1895303007: Non passive touch end or touch cancel listeners should not block scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
index 821b3de34311df44b17143392eb45ab639dfafff..8884238d0c6ce228dc86f785e77f6e9e7a645e88 100644
--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
@@ -911,11 +911,16 @@ bool ChromeClientImpl::shouldOpenModalDialogDuringPageDismissal(const DialogType
void ChromeClientImpl::setEventListenerProperties(WebEventListenerClass eventClass, WebEventListenerProperties properties)
{
- if (eventClass == WebEventListenerClass::Touch)
- m_webView->hasTouchEventHandlers(properties != WebEventListenerProperties::Nothing);
-
- if (WebLayerTreeView* treeView = m_webView->layerTreeView())
+ if (WebLayerTreeView* treeView = m_webView->layerTreeView()) {
treeView->setEventListenerProperties(eventClass, properties);
+ if (eventClass == WebEventListenerClass::TouchStartOrMove) {
+ m_webView->hasTouchEventHandlers(properties != WebEventListenerProperties::Nothing || eventListenerProperties(WebEventListenerClass::TouchEndOrCancel) != WebEventListenerProperties::Nothing);
+ } else if (eventClass == WebEventListenerClass::TouchEndOrCancel) {
+ m_webView->hasTouchEventHandlers(properties != WebEventListenerProperties::Nothing || eventListenerProperties(WebEventListenerClass::TouchStartOrMove) != WebEventListenerProperties::Nothing);
+ }
+ } else {
+ m_webView->hasTouchEventHandlers(true);
+ }
}
WebEventListenerProperties ChromeClientImpl::eventListenerProperties(WebEventListenerClass eventClass) const
@@ -925,13 +930,13 @@ WebEventListenerProperties ChromeClientImpl::eventListenerProperties(WebEventLis
return WebEventListenerProperties::Nothing;
}
-void ChromeClientImpl::setHaveScrollEventHandlers(bool hasEventHandlers)
+void ChromeClientImpl::setHasScrollEventHandlers(bool hasEventHandlers)
{
if (WebLayerTreeView* treeView = m_webView->layerTreeView())
treeView->setHaveScrollEventHandlers(hasEventHandlers);
}
-bool ChromeClientImpl::haveScrollEventHandlers() const
+bool ChromeClientImpl::hasScrollEventHandlers() const
{
if (WebLayerTreeView* treeView = m_webView->layerTreeView())
return treeView->haveScrollEventHandlers();
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | third_party/WebKit/Source/web/WebPagePopupImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698