Android: turn on auto-detect encoding by default

Android: turn on auto-detect encoding by default

Now that CED (Compact Encoding Detection) library replaced
ICU (crrev.com/2081653007), turning on auto-detect encoding
by default became feasible without regression on page
loading time. Also removed the encoding menu in site
setting (originally added in crrev.com/1248163002).

Will remove the menu on the other platforms in a follow-up
CL.

BUG=597488
Committed: https://crrev.com/f0829bf6d80a9109b399580fe48d8c3e1c66eeed
Cr-Commit-Position: refs/heads/master@{#407005}

[Jinsuk Kim, 2016-04-18 05:31:01]

Description was changed from

==========
Android: revert "UI for auto-detect encoding setting"

Encoding-related menu will go away. It's hard to find, rarely used,
turns out not the right solution to the problem. TLD-based default
encoding(crbug.com/583564), UTF-8 encoding detector (crbug.com/583549)
were introduced to mitigate the issues of showing garbled texts for
the pages without propert encoding information. The removal is
a part of the effort to keep Chrome slim.

BUG=597488

This reverts commit 16cbeabb7cb284311275c7eda5bbcc2fce4f4261.

BUG=597488
==========

to

==========
Android: revert "UI for auto-detect encoding setting"

Encoding-related menu will go away. It's hard to find, rarely used,
turns out not the right solution to the problem. TLD-based default
encoding(crbug.com/583564), UTF-8 encoding detector (crbug.com/583549)
were introduced to mitigate the issues of showing garbled texts for
the pages without propert encoding information. The removal is
a part of the effort to keep Chrome slim.

Will remove the menu on the other platforms in a follow-up
CL.

This reverts commit 16cbeabb7cb284311275c7eda5bbcc2fce4f4261.

BUG=597488
==========

[Jinsuk Kim, 2016-04-18 05:33:06]

jinsukkim@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Jinsuk Kim, 2016-07-15 11:40:28]

Description was changed from

==========
Android: revert "UI for auto-detect encoding setting"

Encoding-related menu will go away. It's hard to find, rarely used,
turns out not the right solution to the problem. TLD-based default
encoding(crbug.com/583564), UTF-8 encoding detector (crbug.com/583549)
were introduced to mitigate the issues of showing garbled texts for
the pages without propert encoding information. The removal is
a part of the effort to keep Chrome slim.

Will remove the menu on the other platforms in a follow-up
CL.

This reverts commit 16cbeabb7cb284311275c7eda5bbcc2fce4f4261.

BUG=597488
==========

to

==========
Android: turn on auto-detect encoding by default

Now that CED (Compact Encoding Detection) library replaced
ICU (crrev.com/2081653007), turning on auto-detect encoding
by default became feasible without regression on page
loading time. Also removed the encoding menu in site
setting (crrev.com/1248163002)

Will remove the menu on the other platforms in a follow-up
CL.

BUG=597488
==========

[Jinsuk Kim, 2016-07-15 11:41:34]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 11:41:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 12:53:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 12:53:30]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Jinsuk Kim, 2016-07-17 23:37:57]

Patchset #2 (id:20001) has been deleted

[Jinsuk Kim, 2016-07-18 00:27:40]

Patchset #3 (id:60001) has been deleted

[Ted C, 2016-07-19 00:28:39]

tedchoc@chromium.org changed reviewers:
+ twellington@chromium.org

[Ted C, 2016-07-19 00:28:40]

twellington@ is a better reviewer for this since she added it initially

[Theresa, 2016-07-19 20:18:04]

Looks good overall, just a few comments.

For the commit message, can you change the last sentence to something like:

"... Also removed the encoding menu in site
setting (originally added in crrev.com/1248163002)."

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/java/res...
File chrome/android/java/res/xml/site_settings_preferences.xml (right):

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/java/res...
chrome/android/java/res/xml/site_settings_preferences.xml:65: <Preference
Check with UX to confirm that this should move back down now that we're removing
auto-detect encoding.

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/java/res...
File chrome/android/java/res/xml/translate_preferences.xml (right):

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/java/res...
chrome/android/java/res/xml/translate_preferences.xml:2: <!-- Copyright 2015 The
Chromium Authors. All rights reserved.
nit: 2016

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/TranslatePreferences.java
(right):

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/TranslatePreferences.java:1:
// Copyright 2015 The Chromium Authors. All rights reserved.
nit: 2016

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:790: When this feature is
turned on, Chrome will offer to translate pages written in other languages using
Google Translate.
Also check on this string with UX. We may want to keep the new version. rolfe@
did the UX for auto-detect encoding.

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java
(left):

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java:614:
public void testToggleAutoDetectEncoding() throws Exception {
Now that there's not an explicit toggle, I think removing this means no
auto-detect encoding tests will run on Android because the cc test has been
disabled since 2012:
https://cs.chromium.org/chromium/src/chrome/browser/browser_encoding_browsert...

Can we add a basic encoding test somewhere to make sure that this is working on
Android?

[Jinsuk Kim, 2016-07-19 21:54:06]

Description was changed from

==========
Android: turn on auto-detect encoding by default

Now that CED (Compact Encoding Detection) library replaced
ICU (crrev.com/2081653007), turning on auto-detect encoding
by default became feasible without regression on page
loading time. Also removed the encoding menu in site
setting (crrev.com/1248163002)

Will remove the menu on the other platforms in a follow-up
CL.

BUG=597488
==========

to

==========
Android: turn on auto-detect encoding by default

Now that CED (Compact Encoding Detection) library replaced
ICU (crrev.com/2081653007), turning on auto-detect encoding
by default became feasible without regression on page
loading time. Also removed the encoding menu in site
setting (originally added in crrev.com/1248163002).


Will remove the menu on the other platforms in a follow-up
CL.

BUG=597488
==========

[Jinsuk Kim, 2016-07-19 22:02:03]

jinsukkim@chromium.org changed reviewers:
+ rolfe@chromium.org

[Jinsuk Kim, 2016-07-20 04:04:53]

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/java/res...
File chrome/android/java/res/xml/site_settings_preferences.xml (right):

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/java/res...
chrome/android/java/res/xml/site_settings_preferences.xml:65: <Preference
On 2016/07/19 20:18:03, Theresa Wellington wrote:
> Check with UX to confirm that this should move back down now that we're
removing
> auto-detect encoding.

rolfe@ confirmed that this is okay if it's being exactly reverted.

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/java/res...
File chrome/android/java/res/xml/translate_preferences.xml (right):

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/java/res...
chrome/android/java/res/xml/translate_preferences.xml:2: <!-- Copyright 2015 The
Chromium Authors. All rights reserved.
On 2016/07/19 20:18:03, Theresa Wellington wrote:
> nit: 2016

Done.

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/TranslatePreferences.java
(right):

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/TranslatePreferences.java:1:
// Copyright 2015 The Chromium Authors. All rights reserved.
On 2016/07/19 20:18:03, Theresa Wellington wrote:
> nit: 2016

Done.

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:790: When this feature is
turned on, Chrome will offer to translate pages written in other languages using
Google Translate.
On 2016/07/19 20:18:03, Theresa Wellington wrote:
> Also check on this string with UX. We may want to keep the new version. rolfe@
> did the UX for auto-detect encoding.

rolfe@ confirme that this is right, since we are going back to full-page setting
which needs longer description.

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java
(left):

https://codereview.chromium.org/1894913002/diff/80001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java:614:
public void testToggleAutoDetectEncoding() throws Exception {
On 2016/07/19 20:18:03, Theresa Wellington wrote:
> Now that there's not an explicit toggle, I think removing this means no
> auto-detect encoding tests will run on Android because the cc test has been
> disabled since 2012:
>
https://cs.chromium.org/chromium/src/chrome/browser/browser_encoding_browsert...
> 
> Can we add a basic encoding test somewhere to make sure that this is working
on
> Android?

Revived this test and moved to EncodingTest. Left a TODO about enabling the test
you mentioned above. I think it's possible with the new encoding detection
library.

[Theresa, 2016-07-20 17:34:08]

lgtm

[Jinsuk Kim, 2016-07-20 23:35:29]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 23:35:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 23:45:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 23:45:24]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Jinsuk Kim, 2016-07-21 01:40:25]

On 2016/07/20 17:34:08, Theresa Wellington wrote:
> lgtm

Hi Ted, could you give owner's lgtm for the rest of files?

[Ted C, 2016-07-21 17:07:18]

On 2016/07/21 01:40:25, Jinsuk wrote:
> On 2016/07/20 17:34:08, Theresa Wellington wrote:
> > lgtm
> 
> Hi Ted, could you give owner's lgtm for the rest of files?

lgtm

I'm a bit surprised we have to change the xtbs manually.  I would
have assumed they'd be regenerated based on your grd change, but
they seemed to be checked in so I guess not

[Jinsuk Kim, 2016-07-22 00:38:28]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 00:39:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 02:04:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 02:04:32]

Dry run: This issue passed the CQ dry run.

[Jinsuk Kim, 2016-07-22 02:22:41]

The CQ bit was checked by jinsukkim@chromium.org

[Jinsuk Kim, 2016-07-22 02:22:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org, tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/1894913002/#ps140001
(title: "Fix build error")

[commit-bot: I haz the power, 2016-07-22 02:23:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 03:11:40]

Description was changed from

==========
Android: turn on auto-detect encoding by default

Now that CED (Compact Encoding Detection) library replaced
ICU (crrev.com/2081653007), turning on auto-detect encoding
by default became feasible without regression on page
loading time. Also removed the encoding menu in site
setting (originally added in crrev.com/1248163002).


Will remove the menu on the other platforms in a follow-up
CL.

BUG=597488
==========

to

==========
Android: turn on auto-detect encoding by default

Now that CED (Compact Encoding Detection) library replaced
ICU (crrev.com/2081653007), turning on auto-detect encoding
by default became feasible without regression on page
loading time. Also removed the encoding menu in site
setting (originally added in crrev.com/1248163002).


Will remove the menu on the other platforms in a follow-up
CL.

BUG=597488
==========

[commit-bot: I haz the power, 2016-07-22 03:11:41]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2016-07-22 03:13:13]

Description was changed from

==========
Android: turn on auto-detect encoding by default

Now that CED (Compact Encoding Detection) library replaced
ICU (crrev.com/2081653007), turning on auto-detect encoding
by default became feasible without regression on page
loading time. Also removed the encoding menu in site
setting (originally added in crrev.com/1248163002).


Will remove the menu on the other platforms in a follow-up
CL.

BUG=597488
==========

to

==========
Android: turn on auto-detect encoding by default

Now that CED (Compact Encoding Detection) library replaced
ICU (crrev.com/2081653007), turning on auto-detect encoding
by default became feasible without regression on page
loading time. Also removed the encoding menu in site
setting (originally added in crrev.com/1248163002).

Will remove the menu on the other platforms in a follow-up
CL.

BUG=597488

Committed: https://crrev.com/f0829bf6d80a9109b399580fe48d8c3e1c66eeed
Cr-Commit-Position: refs/heads/master@{#407005}
==========

[commit-bot: I haz the power, 2016-07-22 03:13:15]

Patchset 6 (id:??) landed as
https://crrev.com/f0829bf6d80a9109b399580fe48d8c3e1c66eeed
Cr-Commit-Position: refs/heads/master@{#407005}