Android: turn on auto-detect encoding by default

chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.preferences.website;
 
 import android.content.Intent;
 import android.os.Bundle;
 import android.os.Environment;
 import android.test.suitebuilder.annotation.SmallTest;
 
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.test.util.CommandLineFlags;
 import org.chromium.base.test.util.Feature;
 import org.chromium.chrome.browser.ChromeActivity;
 import org.chromium.chrome.browser.ChromeApplication;
 import org.chromium.chrome.browser.ChromeSwitches;
 import org.chromium.chrome.browser.infobar.InfoBarContainer;
 import org.chromium.chrome.browser.preferences.ChromeBaseCheckBoxPreference;
 import org.chromium.chrome.browser.preferences.ChromeBaseListPreference;
 import org.chromium.chrome.browser.preferences.ChromeSwitchPreference;
 import org.chromium.chrome.browser.preferences.LocationSettings;
 import org.chromium.chrome.browser.preferences.PrefServiceBridge;
 import org.chromium.chrome.browser.preferences.Preferences;
 import org.chromium.chrome.browser.preferences.PreferencesLauncher;
-import org.chromium.chrome.browser.preferences.PreferencesTest;
 import org.chromium.chrome.browser.util.FeatureUtilities;
 import org.chromium.chrome.test.ChromeActivityTestCaseBase;
-import org.chromium.chrome.test.util.ChromeTabUtils;
 import org.chromium.chrome.test.util.InfoBarTestAnimationListener;
 import org.chromium.chrome.test.util.browser.LocationSettingsTestUtil;
 import org.chromium.net.test.EmbeddedTestServer;
 
 import java.util.concurrent.Callable;
 
 /**
  * Tests for everything under Settings > Site Settings.
  */
 public class SiteSettingsPreferencesTest extends ChromeActivityTestCaseBase<ChromeActivity> {
@@ skipping 217 matching lines @@
                         websitePreferences.findPreference(
                                 SingleCategoryPreferences.READ_WRITE_TOGGLE_KEY);
                 websitePreferences.onPreferenceChange(toggle, enabled);
                 assertEquals("Mic should be " + (enabled ? "allowed" : "blocked"),
                         enabled, PrefServiceBridge.getInstance().isMicEnabled());
             }
         });
         preferenceActivity.finish();
     }
 
-    private void setAutoDetectEncoding(final boolean enabled) {
-        Intent intent = PreferencesLauncher.createIntentForSettingsPage(
-                getInstrumentation().getTargetContext(), LanguagePreferences.class.getName());
-        final Preferences preferenceActivity =
-                (Preferences) getInstrumentation().startActivitySync(intent);
-
-        ThreadUtils.runOnUiThread(new Runnable() {
-            @Override
-            public void run() {
-                LanguagePreferences languagePreferences =
-                        (LanguagePreferences) preferenceActivity.getFragmentForTest();
-                ChromeBaseCheckBoxPreference checkbox = (ChromeBaseCheckBoxPreference)
-                        languagePreferences.findPreference(
-                                LanguagePreferences.PREF_AUTO_DETECT_CHECKBOX);
-                if (checkbox.isChecked() != enabled) {
-                    PreferencesTest.clickPreference(languagePreferences, checkbox);
-                }
-                assertEquals("Auto detect encoding should be " + (enabled ? "enabled" : "disabled"),
-                        enabled, PrefServiceBridge.getInstance().isAutoDetectEncodingEnabled());
-            }
-        });
-
-        preferenceActivity.finish();
-    }
-
     private void setEnableKeygen(final String origin, final boolean enabled) {
         Website website = new Website(WebsiteAddress.create(origin));
         website.setKeygenInfo(new KeygenInfo(origin, origin, false));
         final Preferences preferenceActivity = startSingleWebsitePreferences(website);
 
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 SingleWebsitePreferences websitePreferences =
                         (SingleWebsitePreferences) preferenceActivity.getFragmentForTest();
@@ skipping 297 matching lines @@
 
         // Launch a page that uses the microphone and make sure an infobar shows up.
         loadUrl(mTestServer.getURL("/content/test/data/media/getusermedia.html"));
         runJavaScriptCodeInCurrentTab("getUserMediaAndStop({video: false, audio: true});");
 
         assertTrue("InfoBar not added.", listener.addInfoBarAnimationFinished());
         assertEquals("Wrong infobar count", 1, getInfoBars().size());
     }
 
     /**
-     * Toggles auto detect encoding, makes sure it is set correctly, and makes sure the page is
-     * encoded correctly.
-     */
-    @SmallTest
-    @Feature({"Preferences"})
-    public void testToggleAutoDetectEncoding() throws Exception {

[Theresa, 2016/07/19 20:18:03]

Now that there's not an explicit toggle, I think removing this means no
auto-detect encoding tests will run on Android because the cc test has been
disabled since 2012:
https://cs.chromium.org/chromium/src/chrome/browser/browser_encoding_browsert...

Can we add a basic encoding test somewhere to make sure that this is working on
Android?

[Jinsuk Kim, 2016/07/20 04:04:53]

Revived this test and moved to EncodingTest. Left a TODO about enabling the test
you mentioned above. I think it's possible with the new encoding detection
library.

-        String testUrl = mTestServer.getURL(
-                "/chrome/test/data/encoding_tests/auto_detect/"
-                + "Big5_with_no_encoding_specified.html");
-
-        setAutoDetectEncoding(false);
-        loadUrl(testUrl);
-        assertEquals("Wrong page encoding while auto detect encoding disabled", "windows-1252",
-                getActivity().getCurrentContentViewCore().getWebContents().getEncoding());
-
-        setAutoDetectEncoding(true);
-        ThreadUtils.runOnUiThread(new Runnable() {
-            @Override
-            public void run() {
-                getActivity().getActivityTab().reload();
-            }
-        });
-        ChromeTabUtils.waitForTabPageLoaded(getActivity().getActivityTab(), testUrl);
-        assertEquals("Wrong page encoding while auto detect encoding enabled", "Big5",
-                getActivity().getCurrentContentViewCore().getWebContents().getEncoding());
-
-    }
-
-    /**
      * Helper function to test allowing and blocking background sync.
      * @param enabled true to test enabling background sync, false to test disabling the feature.
      */
     private void doTestBackgroundSyncPermission(final boolean enabled) {
         setEnableBackgroundSync(enabled);
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 assertEquals("Background Sync should be " + (enabled ? "enabled" : "disabled"),
                         PrefServiceBridge.getInstance().isBackgroundSyncAllowed(), enabled);
@@ skipping 19 matching lines @@
             public Integer call() throws Exception {
                 if (FeatureUtilities.isDocumentMode(getInstrumentation().getTargetContext())) {
                     return ChromeApplication.getDocumentTabModelSelector().getTotalTabCount();
                 } else {
                     return getActivity().getTabModelSelector().getTotalTabCount();
                 }
             }
         });
     }
 }