MacViews: Implement Full Keyboard Access.

chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc

Index: chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
diff --git a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
index f339b84b90daf235532a111ef073b69868ee8a22..4f4ade4f3036ea5872c483c6324bb7e25276e86b 100644
--- a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
+++ b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
@@ -109,7 +109,7 @@ views::View* ProfileSigninConfirmationDialogViews::CreateExtraView() {
     continue_signin_button_ =
         new views::LabelButton(this, continue_signin_text);
     continue_signin_button_->SetStyle(views::Button::STYLE_BUTTON);
-    continue_signin_button_->SetFocusBehavior(FocusBehavior::ALWAYS);
+    views::Button::ConfigureDefaultFocus(continue_signin_button_);

[Evan Stade, 2016/05/17 18:58:15]

you don't need to do this after calling SetStyle. I think there are many places
that ConfigureDefaultFocus is now called somewhat redundantly (I'm removing this
one in https://codereview.chromium.org/1978403003/ )

[karandeepb, 2016/05/18 00:09:46]

I had removed this in https://codereview.chromium.org/1977353002/. I only found
2 such places when I had last checked. Any reason for saying
ConfigureDefaultFocus is being called redundantly at several places? 

[Evan Stade, 2016/05/18 00:16:32]

Ah, I see that you're already on it. Great. I just ran into two places and
assumed there would be more. (The other being DialogClientView.) 

FWIW, the name is a little confusing to me. The comment above the function is
"Make the |button| focusable as per the platform." which is clear, so why not
make the fn "MakeFocusable" or similar?

   }
   return continue_signin_button_;
 }