Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 1978403003: [MD] Eliminate as many SetStyle(STYLE_BUTTON) calls as possible. (Closed)

Created:
4 years, 7 months ago by Evan Stade
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, tfarina, sync-reviews_chromium.org, oshima+watch_chromium.org, gcasto+watchlist_chromium.org, davemoore+watch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD] Eliminate as many SetStyle(STYLE_BUTTON) calls as possible. The only ones left are a) the old download shelf (going away) b) the old full screen bubble (going away) c) the translate bubble (need to get rid of the weird menu button) d) old task manager (going away) e) new task manager (not sure what to do with this one) BUG=571500 Committed: https://crrev.com/411db4592a21773096ea399c748904f21f41faf0 Cr-Commit-Position: refs/heads/master@{#394261}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -103 lines) Patch
M chrome/browser/chromeos/options/network_config_view.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/first_run/try_chrome_dialog_view.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.h View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc View 2 chunks +7 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 6 chunks +11 lines, -21 lines 0 comments Download
M chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h View 4 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc View 1 6 chunks +15 lines, -18 lines 0 comments Download
M ui/views/controls/button/md_text_button.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/button/md_text_button.cc View 3 chunks +15 lines, -0 lines 0 comments Download
M ui/views/window/dialog_client_view.cc View 1 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Evan Stade
4 years, 7 months ago (2016-05-16 22:54:45 UTC) #2
sky
LGTM - I look forward to CreateSecurityUi*** being nuked. Too confusing.
4 years, 7 months ago (2016-05-17 03:09:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978403003/1
4 years, 7 months ago (2016-05-17 17:27:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/184558)
4 years, 7 months ago (2016-05-17 17:37:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978403003/20001
4 years, 7 months ago (2016-05-17 18:59:55 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-17 23:10:20 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 23:11:24 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/411db4592a21773096ea399c748904f21f41faf0
Cr-Commit-Position: refs/heads/master@{#394261}

Powered by Google App Engine
This is Rietveld 408576698