Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6316)

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior
Patch Set: Rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profiles/profile_chooser_view.cc
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
index adab7ceb6dda278f48c8b0e344896b663fbff249..ba23c02554232f27906667e8e486c22b56d40fc0 100644
--- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
@@ -154,7 +154,7 @@ views::ImageButton* CreateBackButton(views::ButtonListener* listener) {
rb->GetImageSkiaNamed(IDR_BACK_P));
back_button->SetImage(views::ImageButton::STATE_DISABLED,
rb->GetImageSkiaNamed(IDR_BACK_D));
- back_button->SetFocusBehavior(views::View::FocusBehavior::ALWAYS);
+ views::Button::ConfigureDefaultFocus(back_button);
return back_button;
}
@@ -173,7 +173,7 @@ class BackgroundColorHoverButton : public views::LabelButton {
SetMinSize(gfx::Size(0,
kButtonHeight + views::kRelatedControlVerticalSpacing));
SetImage(STATE_NORMAL, icon);
- SetFocusBehavior(FocusBehavior::ALWAYS);
+ Button::ConfigureDefaultFocus(this);
}
~BackgroundColorHoverButton() override {}
@@ -1398,8 +1398,7 @@ views::View* ProfileChooserView::CreateCurrentProfileView(
views::LabelButton::STATE_NORMAL,
gfx::CreateVectorIcon(gfx::VectorIconId::WARNING, 18,
gfx::kChromeIconGrey));
-
- auth_error_email_button_->SetFocusBehavior(FocusBehavior::ALWAYS);
+ views::Button::ConfigureDefaultFocus(auth_error_email_button_);
gfx::Insets insets =
views::LabelButtonAssetBorder::GetDefaultInsetsForStyle(
views::Button::STYLE_TEXTBUTTON);

Powered by Google App Engine
This is Rietveld 408576698