Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1977353002: Views: Remove reduntant Button::ConfigureDefaultFocus calls. (Closed)

Created:
4 years, 7 months ago by karandeepb
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, sync-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@other_fk_regression
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Views: Remove reduntant Button::ConfigureDefaultFocus calls. This CL removes some reduntant calls to Button::ConfigureDefaultFocus(). These calls are reduntant since LabelButton::SetStyle() already calls Button::ConfigureDefaultFocus() and set_request_focus_on_press(true). BUG=NONE Committed: https://crrev.com/9ab1e9feff42d791f85e450ba715af7f305fc883 Cr-Commit-Position: refs/heads/master@{#394057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M ash/shell/lock_view.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (6 generated)
karandeepb
PTAL sky@. This depends on https://codereview.chromium.org/1963563002
4 years, 7 months ago (2016-05-16 11:42:19 UTC) #3
maxbogue
On 2016/05/16 11:42:19, karandeepb wrote: > PTAL sky@. This depends on https://codereview.chromium.org/1963563002 FYI: I believe ...
4 years, 7 months ago (2016-05-16 18:50:53 UTC) #4
sky
LGTM
4 years, 7 months ago (2016-05-16 19:46:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977353002/1
4 years, 7 months ago (2016-05-17 02:36:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/230018)
4 years, 7 months ago (2016-05-17 03:57:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977353002/1
4 years, 7 months ago (2016-05-17 04:43:14 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 05:17:42 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 05:18:56 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ab1e9feff42d791f85e450ba715af7f305fc883
Cr-Commit-Position: refs/heads/master@{#394057}

Powered by Google App Engine
This is Rietveld 408576698