[Sync] Adjust new entity version before commit.

[Sync] Adjust new entity version before commit.

Version of newly created entity on the client is set to -1. Server
doesn't accept entity with version -1, it responds with MIGRATION_DONE
error. commit_util.cc:BuildCommitItem() performs translation of
version -1 to 0 and in addition verifies that id is consistent with
version.

In this change:
- Set version to 0 in ModelTypeWorker for newly created entities
- Rename couple of functions

R=maxbogue@chromium.org
BUG=

Committed: https://crrev.com/4c454e24700b8216969459011619c66bf1a66de0
Cr-Commit-Position: refs/heads/master@{#387972}

[maxbogue, 2016-04-16 00:31:48]

lgtm w/ nit

https://codereview.chromium.org/1893813002/diff/1/sync/engine/model_type_work...
File sync/engine/model_type_worker.cc (right):

https://codereview.chromium.org/1893813002/diff/1/sync/engine/model_type_work...
sync/engine/model_type_worker.cc:312: // TODO(stanisc): This is incorrect for
bookmarks for two reasons:
I think this comment block should still be right above the set_id_string call.

[pavely, 2016-04-18 17:32:04]

https://codereview.chromium.org/1893813002/diff/1/sync/engine/model_type_work...
File sync/engine/model_type_worker.cc (right):

https://codereview.chromium.org/1893813002/diff/1/sync/engine/model_type_work...
sync/engine/model_type_worker.cc:312: // TODO(stanisc): This is incorrect for
bookmarks for two reasons:
On 2016/04/16 00:31:48, maxbogue wrote:
> I think this comment block should still be right above the set_id_string call.

Done.

[pavely, 2016-04-18 17:41:23]

The CQ bit was checked by pavely@chromium.org

[pavely, 2016-04-18 17:41:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxbogue@chromium.org
Link to the patchset: https://codereview.chromium.org/1893813002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-04-18 17:41:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893813002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893813002/40001

[commit-bot: I haz the power, 2016-04-18 18:58:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-18 19:01:59]

Description was changed from

==========
[Sync] Adjust new entity version before commit.

Version of newly created entity on the client is set to -1. Server
doesn't accept entity with version -1, it responds with MIGRATION_DONE
error. commit_util.cc:BuildCommitItem() performs translation of
version -1 to 0 and in addition verifies that id is consistent with
version.

In this change:
- Set version to 0 in ModelTypeWorker for newly created entities
- Rename couple of functions

R=maxbogue@chromium.org
BUG=
==========

to

==========
[Sync] Adjust new entity version before commit.

Version of newly created entity on the client is set to -1. Server
doesn't accept entity with version -1, it responds with MIGRATION_DONE
error. commit_util.cc:BuildCommitItem() performs translation of
version -1 to 0 and in addition verifies that id is consistent with
version.

In this change:
- Set version to 0 in ModelTypeWorker for newly created entities
- Rename couple of functions

R=maxbogue@chromium.org
BUG=

Committed: https://crrev.com/4c454e24700b8216969459011619c66bf1a66de0
Cr-Commit-Position: refs/heads/master@{#387972}
==========

[commit-bot: I haz the power, 2016-04-18 19:02:01]

Patchset 3 (id:??) landed as
https://crrev.com/4c454e24700b8216969459011619c66bf1a66de0
Cr-Commit-Position: refs/heads/master@{#387972}