sync/engine/model_type_worker_unittest.cc - Issue 1893813002: [Sync] Adjust new entity version before commit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/engine/model_type_worker_unittest.cc

Issue 1893813002: [Sync] Adjust new entity version before commit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@DeviceInfoFixes

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/engine/model_type_worker_unittest.cc

diff --git a/sync/engine/model_type_worker_unittest.cc b/sync/engine/model_type_worker_unittest.cc

index 8cca17ce7a2c2cd431ee970f0d657f9926ee3bbe..edcc3af51274dfef65a29007ad1a82371f4c848b 100644

--- a/sync/engine/model_type_worker_unittest.cc

+++ b/sync/engine/model_type_worker_unittest.cc

@@ -698,7 +698,7 @@ TEST_F(ModelTypeWorkerTest, SimpleCommit) {

ASSERT_TRUE(HasCommitEntityOnServer("tag1"));

const sync_pb::SyncEntity& entity = GetLatestCommitEntityOnServer("tag1");

EXPECT_FALSE(entity.id_string().empty());

- EXPECT_EQ(kUncommittedVersion, entity.version());

+ EXPECT_EQ(0, entity.version());

EXPECT_NE(0, entity.mtime());

EXPECT_NE(0, entity.ctime());

EXPECT_FALSE(entity.name().empty());

« no previous file with comments | « sync/engine/model_type_worker.cc ('k') | sync/engine/worker_entity_tracker.h » ('j') | no next file with comments »