Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: sync/engine/model_type_worker.h

Issue 1893813002: [Sync] Adjust new entity version before commit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@DeviceInfoFixes
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/engine/model_type_worker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/model_type_worker.h
diff --git a/sync/engine/model_type_worker.h b/sync/engine/model_type_worker.h
index 2fcc9a4357956a3223edc72f97df46e708425fb2..fae02f016603cfc0794c37349249380f1af3a069 100644
--- a/sync/engine/model_type_worker.h
+++ b/sync/engine/model_type_worker.h
@@ -113,11 +113,10 @@ class SYNC_EXPORT ModelTypeWorker : public syncer::UpdateHandler,
// settings in a good state.
bool CanCommitItems() const;
- // Initializes the parts of a commit entity that are the responsibility of
- // this class, and not the WorkerEntityTracker. Some fields, like the
- // client-assigned ID, can only be set by an entity with knowledge of the
- // entire data type's state.
- void HelpInitializeCommitEntity(sync_pb::SyncEntity* commit_entity);
+ // Takes |commit_entity| populated from fields of WorkerEntityTracker and
+ // adjusts some fields before committing to server. Adjustments include
+ // generating client-assigned ID, encrypting data, etc.
+ void AdjustCommitProto(sync_pb::SyncEntity* commit_entity);
// Attempts to decrypt encrypted updates stored in the EntityMap. If
// successful, will remove the update from the its tracker and forward
« no previous file with comments | « no previous file | sync/engine/model_type_worker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698