Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: sync/engine/worker_entity_tracker_unittest.cc

Issue 1893813002: [Sync] Adjust new entity version before commit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@DeviceInfoFixes
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sync/engine/worker_entity_tracker.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 // Copyright 2014 The Chromium Authors. All rights reserved. 2 // Copyright 2014 The Chromium Authors. All rights reserved.
3 // Use of this source code is governed by a BSD-style license that can be 3 // Use of this source code is governed by a BSD-style license that can be
4 // found in the LICENSE file. 4 // found in the LICENSE file.
5 5
6 #include "sync/engine/worker_entity_tracker.h" 6 #include "sync/engine/worker_entity_tracker.h"
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 // Construct a new entity from a commit request. Then serialize it. 90 // Construct a new entity from a commit request. Then serialize it.
91 TEST_F(WorkerEntityTrackerTest, FromCommitRequest) { 91 TEST_F(WorkerEntityTrackerTest, FromCommitRequest) {
92 const int64_t kSequenceNumber = 22; 92 const int64_t kSequenceNumber = 22;
93 const int64_t kBaseVersion = 33; 93 const int64_t kBaseVersion = 33;
94 CommitRequestData data = MakeCommitRequestData(kSequenceNumber, kBaseVersion); 94 CommitRequestData data = MakeCommitRequestData(kSequenceNumber, kBaseVersion);
95 entity_->RequestCommit(data); 95 entity_->RequestCommit(data);
96 96
97 ASSERT_TRUE(entity_->HasPendingCommit()); 97 ASSERT_TRUE(entity_->HasPendingCommit());
98 sync_pb::SyncEntity pb_entity; 98 sync_pb::SyncEntity pb_entity;
99 int64_t sequence_number = 0; 99 int64_t sequence_number = 0;
100 entity_->PrepareCommitProto(&pb_entity, &sequence_number); 100 entity_->PopulateCommitProto(&pb_entity, &sequence_number);
101 EXPECT_EQ(kSequenceNumber, sequence_number); 101 EXPECT_EQ(kSequenceNumber, sequence_number);
102 EXPECT_EQ(kServerId, pb_entity.id_string()); 102 EXPECT_EQ(kServerId, pb_entity.id_string());
103 EXPECT_EQ(kClientTagHash, pb_entity.client_defined_unique_tag()); 103 EXPECT_EQ(kClientTagHash, pb_entity.client_defined_unique_tag());
104 EXPECT_EQ(kBaseVersion, pb_entity.version()); 104 EXPECT_EQ(kBaseVersion, pb_entity.version());
105 EXPECT_EQ(kCtime, syncer::ProtoTimeToTime(pb_entity.ctime())); 105 EXPECT_EQ(kCtime, syncer::ProtoTimeToTime(pb_entity.ctime()));
106 EXPECT_EQ(kMtime, syncer::ProtoTimeToTime(pb_entity.mtime())); 106 EXPECT_EQ(kMtime, syncer::ProtoTimeToTime(pb_entity.mtime()));
107 EXPECT_FALSE(pb_entity.deleted()); 107 EXPECT_FALSE(pb_entity.deleted());
108 EXPECT_EQ(specifics.preference().name(), 108 EXPECT_EQ(specifics.preference().name(),
109 pb_entity.specifics().preference().name()); 109 pb_entity.specifics().preference().name());
110 EXPECT_EQ(specifics.preference().value(), 110 EXPECT_EQ(specifics.preference().value(),
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 CommitRequestData data = MakeCommitRequestData(22, 33); 144 CommitRequestData data = MakeCommitRequestData(22, 33);
145 entity_->RequestCommit(data); 145 entity_->RequestCommit(data);
146 146
147 EXPECT_TRUE(entity_->HasPendingCommit()); 147 EXPECT_TRUE(entity_->HasPendingCommit());
148 148
149 entity_->ReceiveUpdate(33); // Version 33 == 33. 149 entity_->ReceiveUpdate(33); // Version 33 == 33.
150 EXPECT_TRUE(entity_->HasPendingCommit()); 150 EXPECT_TRUE(entity_->HasPendingCommit());
151 } 151 }
152 152
153 } // namespace syncer_v2 153 } // namespace syncer_v2
OLDNEW
« no previous file with comments | « sync/engine/worker_entity_tracker.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698