Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1891893002: [DevTools] Remove setPauseOnNextStatement from V8RuntimeAgentImpl (Closed)

Created:
4 years, 8 months ago by kozy
Modified:
4 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move-last-result-to-injected-script
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove setPauseOnNextStatement from V8RuntimeAgentImpl InjectedScript::releaseObject and m_session->releaseObjectGroup don't execute JS. BUG=595206 R=dgozman@chromium.org Committed: https://crrev.com/7a05d36037f2035719a8b85cc77cc48d15d170c4 Cr-Commit-Position: refs/heads/master@{#387506}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Depends on Patchset:

Issue 1888813003 Patch 60001

Messages

Total messages: 8 (3 generated)
kozy
ptal
4 years, 8 months ago (2016-04-14 18:59:02 UTC) #1
dgozman
lgtm
4 years, 8 months ago (2016-04-14 19:20:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891893002/20001
4 years, 8 months ago (2016-04-14 23:25:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 01:08:25 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 01:12:18 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7a05d36037f2035719a8b85cc77cc48d15d170c4
Cr-Commit-Position: refs/heads/master@{#387506}

Powered by Google App Engine
This is Rietveld 408576698