Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Issue 1891893002: [DevTools] Remove setPauseOnNextStatement from V8RuntimeAgentImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-last-result-to-injected-script
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 if (!propertiesProtocolArray->length()) 231 if (!propertiesProtocolArray->length())
232 return; 232 return;
233 *internalProperties = propertiesProtocolArray.release(); 233 *internalProperties = propertiesProtocolArray.release();
234 } 234 }
235 235
236 void V8RuntimeAgentImpl::releaseObject(ErrorString* errorString, const String16& objectId) 236 void V8RuntimeAgentImpl::releaseObject(ErrorString* errorString, const String16& objectId)
237 { 237 {
238 InjectedScript::ObjectScope scope(errorString, m_debugger, m_session->contex tGroupId(), objectId); 238 InjectedScript::ObjectScope scope(errorString, m_debugger, m_session->contex tGroupId(), objectId);
239 if (!scope.initialize()) 239 if (!scope.initialize())
240 return; 240 return;
241 bool pausingOnNextStatement = m_debugger->pausingOnNextStatement();
242 if (pausingOnNextStatement)
243 m_debugger->setPauseOnNextStatement(false);
244 scope.injectedScript()->releaseObject(objectId); 241 scope.injectedScript()->releaseObject(objectId);
245 if (pausingOnNextStatement)
246 m_debugger->setPauseOnNextStatement(true);
247 } 242 }
248 243
249 void V8RuntimeAgentImpl::releaseObjectGroup(ErrorString*, const String16& object Group) 244 void V8RuntimeAgentImpl::releaseObjectGroup(ErrorString*, const String16& object Group)
250 { 245 {
251 bool pausingOnNextStatement = m_debugger->pausingOnNextStatement();
252 if (pausingOnNextStatement)
253 m_debugger->setPauseOnNextStatement(false);
254 m_session->releaseObjectGroup(objectGroup); 246 m_session->releaseObjectGroup(objectGroup);
255 if (pausingOnNextStatement)
256 m_debugger->setPauseOnNextStatement(true);
257 } 247 }
258 248
259 void V8RuntimeAgentImpl::run(ErrorString* errorString) 249 void V8RuntimeAgentImpl::run(ErrorString* errorString)
260 { 250 {
261 *errorString = "Not paused"; 251 *errorString = "Not paused";
262 } 252 }
263 253
264 void V8RuntimeAgentImpl::setCustomObjectFormatterEnabled(ErrorString*, bool enab led) 254 void V8RuntimeAgentImpl::setCustomObjectFormatterEnabled(ErrorString*, bool enab led)
265 { 255 {
266 m_state->setBoolean(V8RuntimeAgentImplState::customObjectFormatterEnabled, e nabled); 256 m_state->setBoolean(V8RuntimeAgentImplState::customObjectFormatterEnabled, e nabled);
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
475 } 465 }
476 } 466 }
477 467
478 void V8RuntimeAgentImpl::inspect(PassOwnPtr<protocol::Runtime::RemoteObject> obj ectToInspect, PassOwnPtr<protocol::DictionaryValue> hints) 468 void V8RuntimeAgentImpl::inspect(PassOwnPtr<protocol::Runtime::RemoteObject> obj ectToInspect, PassOwnPtr<protocol::DictionaryValue> hints)
479 { 469 {
480 if (m_enabled) 470 if (m_enabled)
481 m_frontend->inspectRequested(objectToInspect, hints); 471 m_frontend->inspectRequested(objectToInspect, hints);
482 } 472 }
483 473
484 } // namespace blink 474 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698