Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1888813003: [DevTools] Move InjectedScript.lastResult to native (Closed)

Created:
4 years, 8 months ago by kozy
Modified:
4 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move InjectedScript.lastResult to native BUG=595206 R=dgozman@chromium.org Committed: https://crrev.com/1124fbf4e6ae38028a7e016129cd5d8c6fb714c9 Cr-Commit-Position: refs/heads/master@{#387419}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -40 lines) Patch
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 1 2 3 6 chunks +19 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js View 2 chunks +0 lines, -16 lines 0 comments Download

Dependent Patchsets:

Issue 1891893002 Patch 20001

Messages

Total messages: 9 (3 generated)
kozy
ptal!
4 years, 8 months ago (2016-04-14 18:23:58 UTC) #1
dgozman
lgtm https://codereview.chromium.org/1888813003/diff/40001/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right): https://codereview.chromium.org/1888813003/diff/40001/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp#newcode299 third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:299: m_lastEvaluationResult.Reset(m_context->isolate(), value); Inline it?
4 years, 8 months ago (2016-04-14 19:19:07 UTC) #2
kozy
All done. https://codereview.chromium.org/1888813003/diff/40001/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right): https://codereview.chromium.org/1888813003/diff/40001/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp#newcode299 third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:299: m_lastEvaluationResult.Reset(m_context->isolate(), value); On 2016/04/14 19:19:06, dgozman wrote: ...
4 years, 8 months ago (2016-04-14 19:24:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888813003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888813003/60001
4 years, 8 months ago (2016-04-14 19:25:07 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-14 20:58:14 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 20:59:26 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/1124fbf4e6ae38028a7e016129cd5d8c6fb714c9
Cr-Commit-Position: refs/heads/master@{#387419}

Powered by Google App Engine
This is Rietveld 408576698