third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp - Issue 1891893002: [DevTools] Remove setPauseOnNextStatement from V8RuntimeAgentImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Issue 1891893002: [DevTools] Remove setPauseOnNextStatement from V8RuntimeAgentImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-last-result-to-injected-script

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

index d1b70a436e7ba1e442c8cf3ee3525cfa0b5cb483..fe244fa8d89aed97d38aa16bce83164354815d2e 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

@@ -238,22 +238,12 @@ void V8RuntimeAgentImpl::releaseObject(ErrorString* errorString, const String16&

InjectedScript::ObjectScope scope(errorString, m_debugger, m_session->contextGroupId(), objectId);

if (!scope.initialize())

return;

- bool pausingOnNextStatement = m_debugger->pausingOnNextStatement();

- if (pausingOnNextStatement)

- m_debugger->setPauseOnNextStatement(false);

scope.injectedScript()->releaseObject(objectId);

- if (pausingOnNextStatement)

- m_debugger->setPauseOnNextStatement(true);

}

void V8RuntimeAgentImpl::releaseObjectGroup(ErrorString*, const String16& objectGroup)

{

- bool pausingOnNextStatement = m_debugger->pausingOnNextStatement();

- if (pausingOnNextStatement)

- m_debugger->setPauseOnNextStatement(false);

m_session->releaseObjectGroup(objectGroup);

- if (pausingOnNextStatement)

- m_debugger->setPauseOnNextStatement(true);

}

void V8RuntimeAgentImpl::run(ErrorString* errorString)

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp ('k') | no next file » | no next file with comments »