Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 189133004: WebGL TexParameterf and GetTexParameterf needs to handle float param correctly (Closed)

Created:
6 years, 9 months ago by Zhenyao Mo
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

WebGL TexParameterf and GetTexParameterf needs to handle float param correctly Right now the param is always cast to int. BUG=348810 TEST=ToT webgl conformance conformance/extensions/ext-texture-filter-anisotropic.html R=kbr@chromium.org,bajones@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255836

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -89 lines) Patch
M content/common/gpu/texture_image_transport_surface.cc View 1 1 chunk +20 lines, -20 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 chunks +1 line, -2 lines 0 comments Download
M gpu/command_buffer/service/error_state.h View 2 chunks +18 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/error_state.cc View 1 3 chunks +22 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/error_state_mock.h View 1 chunk +8 lines, -1 line 0 comments Download
M gpu/command_buffer/service/framebuffer_manager_unittest.cc View 2 chunks +14 lines, -14 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 5 chunks +10 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 14 chunks +14 lines, -14 lines 0 comments Download
M gpu/command_buffer/service/test_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 2 chunks +9 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 4 chunks +54 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Zhenyao Mo
Please review. This is the chromium side of the CL. Will upload the webkit side ...
6 years, 9 months ago (2014-03-06 23:25:20 UTC) #1
Ken Russell (switch to Gerrit)
LGTM overall. https://codereview.chromium.org/189133004/diff/1/gpu/command_buffer/service/error_state.cc File gpu/command_buffer/service/error_state.cc (right): https://codereview.chromium.org/189133004/diff/1/gpu/command_buffer/service/error_state.cc#newcode141 gpu/command_buffer/service/error_state.cc:141: void ErrorStateImpl::SetGLErrorInvalidParami( Let's reduce code duplication here ...
6 years, 9 months ago (2014-03-07 19:28:30 UTC) #2
Zhenyao Mo
https://codereview.chromium.org/189133004/diff/1/gpu/command_buffer/service/error_state.cc File gpu/command_buffer/service/error_state.cc (right): https://codereview.chromium.org/189133004/diff/1/gpu/command_buffer/service/error_state.cc#newcode141 gpu/command_buffer/service/error_state.cc:141: void ErrorStateImpl::SetGLErrorInvalidParami( On 2014/03/07 19:28:31, Ken Russell wrote: > ...
6 years, 9 months ago (2014-03-07 21:31:23 UTC) #3
Zhenyao Mo
bajones: please take a look.
6 years, 9 months ago (2014-03-07 21:33:29 UTC) #4
bajones
On 2014/03/07 21:33:29, Zhenyao Mo wrote: > bajones: please take a look. LGTM
6 years, 9 months ago (2014-03-07 22:05:04 UTC) #5
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 9 months ago (2014-03-07 22:22:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/189133004/20001
6 years, 9 months ago (2014-03-07 22:23:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/189133004/20001
6 years, 9 months ago (2014-03-08 11:06:45 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 14:08:28 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234316
6 years, 9 months ago (2014-03-08 14:08:28 UTC) #10
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 9 months ago (2014-03-09 06:55:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/189133004/20001
6 years, 9 months ago (2014-03-09 06:55:45 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 08:02:43 UTC) #13
Message was sent while issue was closed. 
Change committed as 255836

Powered by Google App Engine
This is Rietveld 408576698