Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 189133004: WebGL TexParameterf and GetTexParameterf needs to handle float param correctly (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 855561765f62fe8133431a78248fc0b14a9c4c21..74ca454db6e5db0890f73af4069fcb89b0540f0d 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -3098,25 +3098,25 @@ void GLES2DecoderImpl::UpdateParentTextureInfo() {
GL_RGBA,
GL_UNSIGNED_BYTE,
true);
- texture_manager()->SetParameter(
+ texture_manager()->SetParameteri(
"UpdateParentTextureInfo",
GetErrorState(),
offscreen_saved_color_texture_info_.get(),
GL_TEXTURE_MAG_FILTER,
GL_NEAREST);
- texture_manager()->SetParameter(
+ texture_manager()->SetParameteri(
"UpdateParentTextureInfo",
GetErrorState(),
offscreen_saved_color_texture_info_.get(),
GL_TEXTURE_MIN_FILTER,
GL_NEAREST);
- texture_manager()->SetParameter(
+ texture_manager()->SetParameteri(
"UpdateParentTextureInfo",
GetErrorState(),
offscreen_saved_color_texture_info_.get(),
GL_TEXTURE_WRAP_S,
GL_CLAMP_TO_EDGE);
- texture_manager()->SetParameter(
+ texture_manager()->SetParameteri(
"UpdateParentTextureInfo",
GetErrorState(),
offscreen_saved_color_texture_info_.get(),
@@ -5467,9 +5467,8 @@ void GLES2DecoderImpl::DoTexParameterf(
return;
}
- texture_manager()->SetParameter(
- "glTexParameterf", GetErrorState(), texture, pname,
- static_cast<GLint>(param));
+ texture_manager()->SetParameterf(
+ "glTexParameterf", GetErrorState(), texture, pname, param);
}
void GLES2DecoderImpl::DoTexParameteri(
@@ -5481,7 +5480,7 @@ void GLES2DecoderImpl::DoTexParameteri(
return;
}
- texture_manager()->SetParameter(
+ texture_manager()->SetParameteri(
"glTexParameteri", GetErrorState(), texture, pname, param);
}
@@ -5494,9 +5493,8 @@ void GLES2DecoderImpl::DoTexParameterfv(
return;
}
- texture_manager()->SetParameter(
- "glTexParameterfv", GetErrorState(), texture, pname,
- static_cast<GLint>(params[0]));
+ texture_manager()->SetParameterf(
+ "glTexParameterfv", GetErrorState(), texture, pname, *params);
}
void GLES2DecoderImpl::DoTexParameteriv(
@@ -5509,7 +5507,7 @@ void GLES2DecoderImpl::DoTexParameteriv(
return;
}
- texture_manager()->SetParameter(
+ texture_manager()->SetParameteri(
"glTexParameteriv", GetErrorState(), texture, pname, *params);
}

Powered by Google App Engine
This is Rietveld 408576698