Issue 1891153002: Unhide "Zombie-cookies".

Issue 1891153002: Unhide "Zombie-cookies". (Closed)

Created:
4 years, 8 months ago by battre

Modified:
4 years, 8 months ago

Reviewers:
msramek, palmer, markusheintz_

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Unhide "Zombie-cookies". Some cookies would not show up in chrome://settings/cookies or the site info dialog because the source_ in the CanonicalCookie is not persisted beyond browser restarts. https://crrev.com/a6acbbcaccdb4085f17d0eef1f266d48fa4baff0 created a filter to allow only access to HTTP or HTTPS cookies. This CL moves the filtering logic a few lines behind a fall back path. R=msramek@chromium.org,palmer@chromium.org,markusheintz@chromium.org BUG=573317, 601582 Review URL: https://codereview.chromium.org/1870973002 Cr-Commit-Position: refs/heads/master@{#386695} (cherry picked from commit 8e4a0b36ac3989db1afb69dff442fdc85af047da) Committed: https://chromium.googlesource.com/chromium/src/+/44959317e61b85de3c25fdb066cbd8481871f637

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -2 lines)			Patch
	M	chrome/browser/browsing_data/cookies_tree_model.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	chrome/browser/browsing_data/cookies_tree_model_unittest.cc	View		1 chunk	+24 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

battre

4 years, 8 months ago (2016-04-15 07:37:15 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
44959317e61b85de3c25fdb066cbd8481871f637.