Unhide "Zombie-cookies".

Unhide "Zombie-cookies".

Some cookies would not show up in chrome://settings/cookies or
the site info dialog because the source_ in the CanonicalCookie
is not persisted beyond browser restarts.
https://crrev.com/a6acbbcaccdb4085f17d0eef1f266d48fa4baff0 created
a filter to allow only access to HTTP or HTTPS cookies. This CL
moves the filtering logic a few lines behind a fall back path.

R=msramek@chromium.org,palmer@chromium.org,markusheintz@chromium.org
BUG=573317, 601582
Committed: https://crrev.com/8e4a0b36ac3989db1afb69dff442fdc85af047da
Cr-Commit-Position: refs/heads/master@{#386695}

[battre, 2016-04-08 09:31:31]

Hi.

Please review this CL.

Thanks,
Dominic

[msramek, 2016-04-08 10:42:56]

Non-owner LGTM.

Can confirm that this still doesn't show file://host/ cookies, while it fixes
cookies disappearing when the source_ is not persisted.

[markusheintz_, 2016-04-08 11:14:58]

On 2016/04/08 10:42:56, msramek wrote:
> Non-owner LGTM.
> 
> Can confirm that this still doesn't show file://host/ cookies, while it fixes
> cookies disappearing when the source_ is not persisted.

LGTM

[markusheintz_, 2016-04-08 11:15:01]

On 2016/04/08 10:42:56, msramek wrote:
> Non-owner LGTM.
> 
> Can confirm that this still doesn't show file://host/ cookies, while it fixes
> cookies disappearing when the source_ is not persisted.

LGTM

[palmer, 2016-04-11 19:44:46]

LGTM, on the condition that looking at cookies for
file://example.com/foo/bar.html shows 0 cookies, and not cookies for
example.com.

[battre, 2016-04-12 15:01:54]

The CQ bit was checked by battre@chromium.org

[commit-bot: I haz the power, 2016-04-12 15:02:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870973002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870973002/1

[commit-bot: I haz the power, 2016-04-12 15:49:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-12 15:50:47]

Description was changed from

==========
Unhide "Zombie-cookies".

Some cookies would not show up in chrome://settings/cookies or
the site info dialog because the source_ in the CanonicalCookie
is not persisted beyond browser restarts.
https://crrev.com/a6acbbcaccdb4085f17d0eef1f266d48fa4baff0 created
a filter to allow only access to HTTP or HTTPS cookies. This CL
moves the filtering logic a few lines behind a fall back path.

R=msramek@chromium.org,palmer@chromium.org,markusheintz@chromium.org
BUG=573317,601582
==========

to

==========
Unhide "Zombie-cookies".

Some cookies would not show up in chrome://settings/cookies or
the site info dialog because the source_ in the CanonicalCookie
is not persisted beyond browser restarts.
https://crrev.com/a6acbbcaccdb4085f17d0eef1f266d48fa4baff0 created
a filter to allow only access to HTTP or HTTPS cookies. This CL
moves the filtering logic a few lines behind a fall back path.

R=msramek@chromium.org,palmer@chromium.org,markusheintz@chromium.org
BUG=573317,601582

Committed: https://crrev.com/8e4a0b36ac3989db1afb69dff442fdc85af047da
Cr-Commit-Position: refs/heads/master@{#386695}
==========

[commit-bot: I haz the power, 2016-04-12 15:50:48]

Patchset 1 (id:??) landed as
https://crrev.com/8e4a0b36ac3989db1afb69dff442fdc85af047da
Cr-Commit-Position: refs/heads/master@{#386695}