Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Unified Diff: chrome/browser/browsing_data/cookies_tree_model_unittest.cc

Issue 1891153002: Unhide "Zombie-cookies". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browsing_data/cookies_tree_model.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data/cookies_tree_model_unittest.cc
diff --git a/chrome/browser/browsing_data/cookies_tree_model_unittest.cc b/chrome/browser/browsing_data/cookies_tree_model_unittest.cc
index 84fed30197057f01f6284d8e01b9b53946ee50f8..e78380805dfacba7226bc931da6582863ee347ad 100644
--- a/chrome/browser/browsing_data/cookies_tree_model_unittest.cc
+++ b/chrome/browser/browsing_data/cookies_tree_model_unittest.cc
@@ -1629,4 +1629,28 @@ TEST_F(CookiesTreeModelTest, CanonicalizeCookieSource) {
cookie_settings, GURL("http://example4.com"));
}
+TEST_F(CookiesTreeModelTest, CookiesFilterWithoutSource) {
+ // CanonicalCookies don't persist their source_ field. This is a regression
+ // test for crbug.com/601582.
+ LocalDataContainer* container =
+ new LocalDataContainer(mock_browsing_data_cookie_helper_.get(),
+ mock_browsing_data_database_helper_.get(),
+ mock_browsing_data_local_storage_helper_.get(),
+ mock_browsing_data_session_storage_helper_.get(),
+ mock_browsing_data_appcache_helper_.get(),
+ mock_browsing_data_indexed_db_helper_.get(),
+ mock_browsing_data_file_system_helper_.get(),
+ mock_browsing_data_quota_helper_.get(),
+ mock_browsing_data_channel_id_helper_.get(),
+ mock_browsing_data_service_worker_helper_.get(),
+ mock_browsing_data_cache_storage_helper_.get(),
+ mock_browsing_data_flash_lso_helper_.get());
+ CookiesTreeModel cookies_model(container, special_storage_policy(), false);
+
+ mock_browsing_data_cookie_helper_->
+ AddCookieSamples(GURL(), "A=1");
+ mock_browsing_data_cookie_helper_->Notify();
+ EXPECT_EQ("A", GetDisplayedCookies(&cookies_model));
+}
+
} // namespace
« no previous file with comments | « chrome/browser/browsing_data/cookies_tree_model.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698