Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: chrome/browser/browsing_data/cookies_tree_model.cc

Issue 1891153002: Unhide "Zombie-cookies". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browsing_data/cookies_tree_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data/cookies_tree_model.cc
diff --git a/chrome/browser/browsing_data/cookies_tree_model.cc b/chrome/browser/browsing_data/cookies_tree_model.cc
index a8fc041d6245e539d1b495c729b4b8f220dd505a..cd94f346cd3011b5088d86fd45956bcb1e186ec5 100644
--- a/chrome/browser/browsing_data/cookies_tree_model.cc
+++ b/chrome/browser/browsing_data/cookies_tree_model.cc
@@ -1221,8 +1221,6 @@ void CookiesTreeModel::PopulateCookieInfoWithFilter(
for (CookieList::iterator it = container->cookie_list_.begin();
it != container->cookie_list_.end(); ++it) {
GURL source = CanonicalizeCookieSource(*it);
- if (!source.SchemeIsHTTPOrHTTPS())
- continue;
if (source.is_empty() || !group_by_cookie_source_) {
std::string domain = it->Domain();
if (domain.length() > 1 && domain[0] == '.')
@@ -1232,6 +1230,8 @@ void CookiesTreeModel::PopulateCookieInfoWithFilter(
source = GURL(std::string(url::kHttpScheme) +
url::kStandardSchemeSeparator + domain + "/");
}
+ if (!source.SchemeIsHTTPOrHTTPS())
+ continue;
if (filter.empty() || (CookieTreeHostNode::TitleForUrl(source)
.find(filter) != base::string16::npos)) {
« no previous file with comments | « no previous file | chrome/browser/browsing_data/cookies_tree_model_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698