Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1890973006: Avoid narrowing to StringC in CPDF_Name and CPDF_NameTree (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Avoid narrowing to StringC in CPDF_Name and CPDF_NameTree Remove redundant CPDF_Name constructors given promotion rules. Rework one char* in CPDF_PageContentGenerator. Committed: https://pdfium.googlesource.com/pdfium/+/e0ad6a4af5d9c5f5671a9ecd0aa437dedae52b16

Patch Set 1 #

Patch Set 2 : Missing !, use initializer list. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_edit/include/cpdf_pagecontentgenerator.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_name.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_name.h View 1 chunk +0 lines, -2 lines 0 comments Download
M core/fpdfdoc/doc_basic.cpp View 1 2 chunks +13 lines, -6 lines 0 comments Download
M core/fpdfdoc/include/fpdf_doc.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Tom Sepez
Lei, for review.
4 years, 8 months ago (2016-04-15 20:54:59 UTC) #4
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-15 21:30:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890973006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890973006/20001
4 years, 8 months ago (2016-04-15 21:32:33 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 21:32:53 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/e0ad6a4af5d9c5f5671a9ecd0aa437dedae5...

Powered by Google App Engine
This is Rietveld 408576698