core/fpdfapi/fpdf_parser/cpdf_name.cpp - Issue 1890973006: Avoid narrowing to StringC in CPDF_Name and CPDF_NameTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_name.cpp

Issue 1890973006: Avoid narrowing to StringC in CPDF_Name and CPDF_NameTree (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Missing !, use initializer list. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_name.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_name.cpp b/core/fpdfapi/fpdf_parser/cpdf_name.cpp

index 2999772aecdbab1d1ae61222b285b364416aa6f0..7d67b51d7c90c063fdc564298f80e58a53514c29 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_name.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_name.cpp

@@ -10,10 +10,6 @@

CPDF_Name::CPDF_Name(const CFX_ByteString& str) : m_Name(str) {}

-CPDF_Name::CPDF_Name(const CFX_ByteStringC& str) : m_Name(str) {}

-CPDF_Name::CPDF_Name(const FX_CHAR* str) : m_Name(str) {}

CPDF_Name::~CPDF_Name() {}

CPDF_Object::Type CPDF_Name::GetType() const {