core/fpdfapi/fpdf_edit/include/cpdf_pagecontentgenerator.h - Issue 1890973006: Avoid narrowing to StringC in CPDF_Name and CPDF_NameTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_edit/include/cpdf_pagecontentgenerator.h

Issue 1890973006: Avoid narrowing to StringC in CPDF_Name and CPDF_NameTree (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Missing !, use initializer list. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_edit/include/cpdf_pagecontentgenerator.h

diff --git a/core/fpdfapi/fpdf_edit/include/cpdf_pagecontentgenerator.h b/core/fpdfapi/fpdf_edit/include/cpdf_pagecontentgenerator.h

index 564a9ff54c82ede3e234fcce9e258881c74c107f..f60b083be125dcc5818db9565e0c789ae4e44de2 100644

--- a/core/fpdfapi/fpdf_edit/include/cpdf_pagecontentgenerator.h

+++ b/core/fpdfapi/fpdf_edit/include/cpdf_pagecontentgenerator.h

@@ -32,7 +32,7 @@ class CPDF_PageContentGenerator {

uint32_t size,

CFX_Matrix& matrix);

CFX_ByteString RealizeResource(CPDF_Object* pResourceObj,

- const FX_CHAR* szType);

+ const CFX_ByteString& bsType);

CPDF_Page* m_pPage;

CPDF_Document* m_pDocument;