Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: core/fpdfapi/fpdf_parser/include/cpdf_name.h

Issue 1890973006: Avoid narrowing to StringC in CPDF_Name and CPDF_NameTree (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Missing !, use initializer list. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_name.cpp ('k') | core/fpdfdoc/doc_basic.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_NAME_H_ 7 #ifndef CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_NAME_H_
8 #define CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_NAME_H_ 8 #define CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_NAME_H_
9 9
10 #include "core/fpdfapi/fpdf_parser/include/cpdf_object.h" 10 #include "core/fpdfapi/fpdf_parser/include/cpdf_object.h"
11 11
12 class CPDF_Name : public CPDF_Object { 12 class CPDF_Name : public CPDF_Object {
13 public: 13 public:
14 explicit CPDF_Name(const CFX_ByteString& str); 14 explicit CPDF_Name(const CFX_ByteString& str);
15 explicit CPDF_Name(const CFX_ByteStringC& str);
16 explicit CPDF_Name(const FX_CHAR* str);
17 15
18 // CPDF_Object. 16 // CPDF_Object.
19 Type GetType() const override; 17 Type GetType() const override;
20 CPDF_Object* Clone(FX_BOOL bDirect = FALSE) const override; 18 CPDF_Object* Clone(FX_BOOL bDirect = FALSE) const override;
21 CFX_ByteString GetString() const override; 19 CFX_ByteString GetString() const override;
22 CFX_WideString GetUnicodeText() const override; 20 CFX_WideString GetUnicodeText() const override;
23 void SetString(const CFX_ByteString& str) override; 21 void SetString(const CFX_ByteString& str) override;
24 bool IsName() const override; 22 bool IsName() const override;
25 CPDF_Name* AsName() override; 23 CPDF_Name* AsName() override;
26 const CPDF_Name* AsName() const override; 24 const CPDF_Name* AsName() const override;
27 25
28 protected: 26 protected:
29 ~CPDF_Name() override; 27 ~CPDF_Name() override;
30 28
31 CFX_ByteString m_Name; 29 CFX_ByteString m_Name;
32 }; 30 };
33 31
34 #endif // CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_NAME_H_ 32 #endif // CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_NAME_H_
OLDNEW
« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_name.cpp ('k') | core/fpdfdoc/doc_basic.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698