[iOS/Mac/GN] Hoist the public_configs for a framework bundle into the base template.

[iOS/Mac/GN] Hoist the public_configs for a framework bundle into the base template.

Both Mac and iOS framework bundles need to be able to be linked to
dependent targets.

BUG=297668
R=sdefresne@chromium.org

Committed: https://crrev.com/8e3fce1153954f539cd246e8d6c3867c204e5c61
Cr-Commit-Position: refs/heads/master@{#387917}

[Robert Sesek, 2016-04-15 21:04:17]

Patchset #2 (id:20001) has been deleted

[sdefresne, 2016-04-18 09:02:59]

lgtm

https://codereview.chromium.org/1890263002/diff/40001/build/config/mac/rules.gni
File build/config/mac/rules.gni (right):

https://codereview.chromium.org/1890263002/diff/40001/build/config/mac/rules....
build/config/mac/rules.gni:79: # TODO(sdefresne): should we have a
framework_dirs similar to lib_dirs
nit: can you add visibility?

visibility = [ ":$_framework_target" ]

https://codereview.chromium.org/1890263002/diff/40001/build/config/mac/rules....
build/config/mac/rules.gni:109: if (!defined(public_configs)) {
You do not forward the public_configs in "forward_variables_from" so, this
should not be defined and can be simplified to:

public_configs = [ ":$_framework_public_config" ]

[Robert Sesek, 2016-04-18 15:13:09]

https://codereview.chromium.org/1890263002/diff/40001/build/config/mac/rules.gni
File build/config/mac/rules.gni (right):

https://codereview.chromium.org/1890263002/diff/40001/build/config/mac/rules....
build/config/mac/rules.gni:79: # TODO(sdefresne): should we have a
framework_dirs similar to lib_dirs
On 2016/04/18 09:02:58, sdefresne wrote:
> nit: can you add visibility?
> 
> visibility = [ ":$_framework_target" ]

Done.

https://codereview.chromium.org/1890263002/diff/40001/build/config/mac/rules....
build/config/mac/rules.gni:109: if (!defined(public_configs)) {
On 2016/04/18 09:02:58, sdefresne wrote:
> You do not forward the public_configs in "forward_variables_from" so, this
> should not be defined and can be simplified to:
> 
> public_configs = [ ":$_framework_public_config" ]

Done.

[Robert Sesek, 2016-04-18 15:13:11]

The CQ bit was checked by rsesek@chromium.org

[Robert Sesek, 2016-04-18 15:13:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/1890263002/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2016-04-18 15:13:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1890263002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1890263002/60001

[commit-bot: I haz the power, 2016-04-18 15:55:45]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-04-18 15:56:58]

Description was changed from

==========
[iOS/Mac/GN] Hoist the public_configs for a framework bundle into the base
template.

Both Mac and iOS framework bundles need to be able to be linked to
dependent targets.

BUG=297668
R=sdefresne@chromium.org
==========

to

==========
[iOS/Mac/GN] Hoist the public_configs for a framework bundle into the base
template.

Both Mac and iOS framework bundles need to be able to be linked to
dependent targets.

BUG=297668
R=sdefresne@chromium.org

Committed: https://crrev.com/8e3fce1153954f539cd246e8d6c3867c204e5c61
Cr-Commit-Position: refs/heads/master@{#387917}
==========

[commit-bot: I haz the power, 2016-04-18 15:56:59]

Patchset 3 (id:??) landed as
https://crrev.com/8e3fce1153954f539cd246e8d6c3867c204e5c61
Cr-Commit-Position: refs/heads/master@{#387917}