Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: build/config/ios/rules.gni

Issue 1890263002: [iOS/Mac/GN] Hoist the public_configs for a framework bundle into the base template. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/mac/rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/ios/rules.gni
diff --git a/build/config/ios/rules.gni b/build/config/ios/rules.gni
index 3265700309f9f5595524b5ddb7fdfa71992f3ac6..171dbf526be4b057de136cf2f913a30eee6cfaf8 100644
--- a/build/config/ios/rules.gni
+++ b/build/config/ios/rules.gni
@@ -330,18 +330,6 @@ template("ios_framework_bundle") {
]
}
- _framework_public_config = _target_name + "_public_config"
- config(_framework_public_config) {
- # TODO(sdefresne): should we have a framework_dirs similar to lib_dirs
- # and include_dirs to avoid duplicate values on the command-line.
- common_flags = [ "-F" + rebase_path("$root_out_dir/.", root_out_dir) ]
- cflags_objc = common_flags
- cflags_objcc = common_flags
- ldflags = common_flags
- lib_dirs = [ root_out_dir ]
- libs = [ _framework_name ]
- }
-
group(_framework_headers_target) {
deps = [
":$_compile_headers_map_target",
@@ -383,13 +371,9 @@ template("ios_framework_bundle") {
"public_configs",
])
- deps = [
+ public_deps = [
":$_framework_target",
]
- if (!defined(public_configs)) {
- public_configs = []
- }
- public_configs += [ ":$_framework_public_config" ]
}
}
}
« no previous file with comments | « no previous file | build/config/mac/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698