Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: build/config/mac/rules.gni

Issue 1890263002: [iOS/Mac/GN] Hoist the public_configs for a framework bundle into the base template. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/ios/rules.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/rules.gni
diff --git a/build/config/mac/rules.gni b/build/config/mac/rules.gni
index f8ec3613d48c35c17834f9b4f000f090df579337..4a910d8b8f76a0517bcc337f8304831e946d743b 100644
--- a/build/config/mac/rules.gni
+++ b/build/config/mac/rules.gni
@@ -74,6 +74,19 @@ template("framework_bundle") {
]
}
+ _framework_public_config = _target_name + "_public_config"
+ config(_framework_public_config) {
+ # TODO(sdefresne): should we have a framework_dirs similar to lib_dirs
+ # and include_dirs to avoid duplicate values on the command-line.
+ visibility = [ ":$_framework_target" ]
+ common_flags = [ "-F" + rebase_path("$root_out_dir/.", root_out_dir) ]
+ cflags_objc = common_flags
+ cflags_objcc = common_flags
+ ldflags = common_flags
+ lib_dirs = [ root_out_dir ]
+ libs = [ _framework_name ]
+ }
+
create_bundle(_framework_target) {
forward_variables_from(invoker,
[
@@ -94,6 +107,8 @@ template("framework_bundle") {
}
public_deps += [ ":$_shared_library_bundle_data" ]
+ public_configs = [ ":$_framework_public_config" ]
+
bundle_root_dir = _framework_root_dir
bundle_resources_dir = "$bundle_root_dir/Resources"
bundle_executable_dir = "$bundle_root_dir"
« no previous file with comments | « build/config/ios/rules.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698