[iOS/Mac/GN] Hoist the public_configs for a framework bundle into the base template.

build/config/mac/rules.gni

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/toolchain/toolchain.gni")
 
 # This is used as the base template for both iOS and Mac frameworks..
 #
 # Arguments
 #
@@ skipping 56 matching lines @@
       "$target_out_dir/$_shared_library_target/$_output_name",
     ]
     outputs = [
       "{{bundle_executable_dir}}/$_output_name",
     ]
     public_deps = [
       ":$_shared_library_target",
     ]
   }
 
+  _framework_public_config = _target_name + "_public_config"
+  config(_framework_public_config) {
+    # TODO(sdefresne): should we have a framework_dirs similar to lib_dirs

[sdefresne, 2016/04/18 09:02:58]

nit: can you add visibility?

visibility = [ ":$_framework_target" ]

[Robert Sesek, 2016/04/18 15:13:09]

Done.

+    # and include_dirs to avoid duplicate values on the command-line.
+    common_flags = [ "-F" + rebase_path("$root_out_dir/.", root_out_dir) ]
+    cflags_objc = common_flags
+    cflags_objcc = common_flags
+    ldflags = common_flags
+    lib_dirs = [ root_out_dir ]
+    libs = [ _framework_name ]
+  }
+
   create_bundle(_framework_target) {
     forward_variables_from(invoker,
                            [
                              "data_deps",
                              "deps",
                              "public_deps",
                              "testonly",
                            ])
 
     if (defined(_framework_version)) {
       visibility = [ ":$_target_name" ]
     } else {
       forward_variables_from(invoker, [ "visibility" ])
     }
 
     if (!defined(public_deps)) {
       public_deps = []
     }
     public_deps += [ ":$_shared_library_bundle_data" ]
 
+    if (!defined(public_configs)) {

[sdefresne, 2016/04/18 09:02:58]

You do not forward the public_configs in "forward_variables_from" so, this
should not be defined and can be simplified to:

public_configs = [ ":$_framework_public_config" ]

[Robert Sesek, 2016/04/18 15:13:09]

Done.

+      public_configs = []
+    }
+    public_configs += [ ":$_framework_public_config" ]
+
     bundle_root_dir = _framework_root_dir
     bundle_resources_dir = "$bundle_root_dir/Resources"
     bundle_executable_dir = "$bundle_root_dir"
   }
 
   if (defined(_framework_version)) {
     action(_target_name) {
       forward_variables_from(invoker,
                              [
                                "visibility",
@@ skipping 58 matching lines @@
 
   framework_bundle(target_name) {
     forward_variables_from(invoker, "*", [ "info_plist" ])
 
     if (!defined(deps)) {
       deps = []
     }
     deps += [ ":$_info_plist_bundle_data" ]
   }
 }