Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 1888713002: cc: Merge TileTaskRunner to TileTaskWorkerPool. (Closed)

Created:
4 years, 8 months ago by prashant.n
Modified:
4 years, 8 months ago
Reviewers:
reveman, vmpstr, ericrk
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@rename_tile_task_client
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Merge TileTaskRunner to TileTaskWorkerPool. This patches merges all interface functions of TileTaskRunner to TileTaskWorkerPool. BUG=599863 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/6cb1bb8c566eedf7c10ee1a367d83c2a6ac6a898 Cr-Commit-Position: refs/heads/master@{#388430}

Patch Set 1 #

Patch Set 2 : changed dependency patch #

Total comments: 10

Patch Set 3 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -322 lines) Patch
M cc/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/cc.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/raster/bitmap_tile_task_worker_pool.h View 1 3 chunks +0 lines, -5 lines 0 comments Download
M cc/raster/bitmap_tile_task_worker_pool.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M cc/raster/gpu_tile_task_worker_pool.h View 1 3 chunks +0 lines, -5 lines 0 comments Download
M cc/raster/gpu_tile_task_worker_pool.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M cc/raster/one_copy_tile_task_worker_pool.h View 1 3 chunks +0 lines, -5 lines 0 comments Download
M cc/raster/one_copy_tile_task_worker_pool.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
A cc/raster/tile_task.h View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
A + cc/raster/tile_task.cc View 1 2 2 chunks +3 lines, -22 lines 0 comments Download
D cc/raster/tile_task_runner.h View 1 1 chunk +0 lines, -93 lines 0 comments Download
D cc/raster/tile_task_runner.cc View 1 1 chunk +0 lines, -75 lines 0 comments Download
M cc/raster/tile_task_worker_pool.h View 1 2 3 chunks +34 lines, -3 lines 0 comments Download
M cc/raster/tile_task_worker_pool.cc View 1 2 chunks +21 lines, -0 lines 0 comments Download
M cc/raster/tile_task_worker_pool_perftest.cc View 1 5 chunks +10 lines, -11 lines 0 comments Download
M cc/raster/tile_task_worker_pool_unittest.cc View 1 3 chunks +5 lines, -6 lines 0 comments Download
M cc/raster/zero_copy_tile_task_worker_pool.h View 1 3 chunks +0 lines, -5 lines 0 comments Download
M cc/raster/zero_copy_tile_task_worker_pool.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M cc/test/fake_tile_manager.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M cc/tiles/gpu_image_decode_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/tiles/gpu_image_decode_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/tiles/software_image_decode_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/tiles/software_image_decode_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/tiles/software_image_decode_controller_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/tiles/tile.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/tiles/tile_draw_info.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/tiles/tile_manager.h View 1 5 chunks +6 lines, -5 lines 0 comments Download
M cc/tiles/tile_manager.cc View 1 2 16 chunks +25 lines, -26 lines 0 comments Download
M cc/tiles/tile_manager_perftest.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 1 7 chunks +32 lines, -22 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (7 generated)
prashant.n
ptal.
4 years, 8 months ago (2016-04-14 06:34:53 UTC) #3
prashant.n
ptal - patch #4.
4 years, 8 months ago (2016-04-15 07:05:05 UTC) #4
prashant.n
ping
4 years, 8 months ago (2016-04-17 18:30:07 UTC) #5
prashant.n
ptal.
4 years, 8 months ago (2016-04-19 07:28:11 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888713002/20001
4 years, 8 months ago (2016-04-19 10:28:54 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-19 11:33:29 UTC) #10
ericrk
LGTM Nice refactor - a couple comments, but overall looks good. https://codereview.chromium.org/1888713002/diff/20001/cc/raster/tile_task.cc File cc/raster/tile_task.cc (left): ...
4 years, 8 months ago (2016-04-20 00:22:29 UTC) #11
prashant.n
https://codereview.chromium.org/1888713002/diff/20001/cc/raster/tile_task.cc File cc/raster/tile_task.cc (left): https://codereview.chromium.org/1888713002/diff/20001/cc/raster/tile_task.cc#oldcode18 cc/raster/tile_task.cc:18: dependencies_(std::move(*dependencies)), On 2016/04/20 00:22:29, ericrk wrote: > should we ...
4 years, 8 months ago (2016-04-20 02:04:48 UTC) #12
reveman
lgtm but we should really remove the TileTaskWorkerPool classes completely in favor of just having ...
4 years, 8 months ago (2016-04-20 02:24:44 UTC) #13
prashant.n
On 2016/04/20 02:24:44, reveman wrote: > lgtm but we should really remove the TileTaskWorkerPool classes ...
4 years, 8 months ago (2016-04-20 04:00:42 UTC) #14
prashant.n
https://codereview.chromium.org/1888713002/diff/20001/cc/raster/tile_task_worker_pool.h File cc/raster/tile_task_worker_pool.h (right): https://codereview.chromium.org/1888713002/diff/20001/cc/raster/tile_task_worker_pool.h#newcode27 cc/raster/tile_task_worker_pool.h:27: class CC_EXPORT TileTaskWorkerPool { As David suggested, we should ...
4 years, 8 months ago (2016-04-20 04:16:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1888713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1888713002/40001
4 years, 8 months ago (2016-04-20 04:16:40 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-20 05:16:08 UTC) #19
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:21:02 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6cb1bb8c566eedf7c10ee1a367d83c2a6ac6a898
Cr-Commit-Position: refs/heads/master@{#388430}

Powered by Google App Engine
This is Rietveld 408576698