Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1909953002: cc: Do not add already failed image decode tasks as dependencies. (Closed)

Created:
4 years, 8 months ago by prashant.n
Modified:
4 years, 8 months ago
Reviewers:
reveman, vmpstr, ericrk
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@task_states
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Do not add already failed image decode tasks as dependencies. When gpu decoding is used, do not add image tasks which have already failed in decoding as dependencies for raster task. BUG=606117 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/68f3b80bd5f76377e0b4bb067fd8e759d33cefc3 Cr-Commit-Position: refs/heads/master@{#389365}

Patch Set 1 #

Patch Set 2 : changed patch dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M cc/tiles/gpu_image_decode_controller.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (9 generated)
prashant.n
ptal.
4 years, 8 months ago (2016-04-21 13:56:39 UTC) #3
prashant.n
ping
4 years, 8 months ago (2016-04-21 21:59:47 UTC) #4
ericrk
LGTM - can you add a unit test to ensure that this behavior doesn't regress?
4 years, 8 months ago (2016-04-22 22:14:48 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 1903733003 Patch 60001). Please resolve the dependency and ...
4 years, 8 months ago (2016-04-23 02:24:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909953002/20001
4 years, 8 months ago (2016-04-23 04:14:34 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-23 05:18:00 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/68f3b80bd5f76377e0b4bb067fd8e759d33cefc3 Cr-Commit-Position: refs/heads/master@{#389365}
4 years, 8 months ago (2016-04-23 05:19:22 UTC) #16
prashant.n
4 years, 8 months ago (2016-04-23 09:29:30 UTC) #17
Message was sent while issue was closed.
On 2016/04/22 22:14:48, ericrk wrote:
> LGTM - can you add a unit test to ensure that this behavior doesn't regress?

In another CL, I'll add unit test.

Powered by Google App Engine
This is Rietveld 408576698