Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1912513003: cc: Fix regression in TileManager InsertNodeForDecodeTask(). (Closed)

Created:
4 years, 8 months ago by prashant.n
Modified:
4 years, 8 months ago
Reviewers:
reveman, vmpstr, ericrk
CC:
chromium-reviews, cc-bugs_chromium.org, ssamanoori_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@land_merge_tile_task_runner
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix regression in TileManager InsertNodeForDecodeTask(). For already-uploaded image, ImageDecodeTaskImpl is not created. The ImageUploadTaskImpl should hold valid decode dependency in |dependencies_|. BUG=605417 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M cc/tiles/gpu_image_decode_controller.cc View 1 chunk +5 lines, -1 line 0 comments Download
M cc/tiles/tile_manager.cc View 1 chunk +2 lines, -0 lines 1 comment Download

Depends on Patchset:

Issue 1888713002 Patch 40001

Messages

Total messages: 5 (2 generated)
prashant.n
PTAL.
4 years, 8 months ago (2016-04-21 11:36:48 UTC) #3
prashant.n
https://codereview.chromium.org/1912513003/diff/1/cc/tiles/tile_manager.cc File cc/tiles/tile_manager.cc (right): https://codereview.chromium.org/1912513003/diff/1/cc/tiles/tile_manager.cc#newcode162 cc/tiles/tile_manager.cc:162: if (task->dependencies().size()) { ericrk@, should we create a node ...
4 years, 8 months ago (2016-04-21 12:19:34 UTC) #4
vmpstr
4 years, 8 months ago (2016-04-21 18:30:48 UTC) #5 
On 2016/04/21 12:19:34, prashant.n wrote:
> https://codereview.chromium.org/1912513003/diff/1/cc/tiles/tile_manager.cc
> File cc/tiles/tile_manager.cc (right):
> 
>
https://codereview.chromium.org/1912513003/diff/1/cc/tiles/tile_manager.cc#ne...
> cc/tiles/tile_manager.cc:162: if (task->dependencies().size()) {
> ericrk@, should we create a node for imageuploadtaskimpl, if image is already
> uploaded??

I think ericrk@ already has a fix here:
https://codereview.chromium.org/1910663002/

Powered by Google App Engine
This is Rietveld 408576698