Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1651)

Issue 1887593003: CC Animation: Make layer_animation_controller a private member of ElementAnimations. (Closed)

Created:
4 years, 8 months ago by loyso (OOO)
Modified:
4 years, 8 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Make layer_animation_controller a private member of ElementAnimations. LayerAnimationController will be merged to ElementAnimations in the dependent CL. BUG=595571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/de0a0025d97917aabb9574f4e69e87215f5bb871 Cr-Commit-Position: refs/heads/master@{#387525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -74 lines) Patch
M cc/animation/animation_host.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/animation/animation_player.cc View 4 chunks +6 lines, -11 lines 0 comments Download
M cc/animation/animation_player_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/animation/element_animations.h View 2 chunks +20 lines, -4 lines 0 comments Download
M cc/animation/element_animations.cc View 1 chunk +44 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 13 chunks +33 lines, -47 lines 0 comments Download
M ui/compositor/layer_animator.cc View 3 chunks +7 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
loyso (OOO)
4 years, 8 months ago (2016-04-14 03:49:55 UTC) #4
ajuma
lgtm
4 years, 8 months ago (2016-04-14 14:01:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887593003/1
4 years, 8 months ago (2016-04-15 00:39:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 02:28:50 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 02:30:31 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de0a0025d97917aabb9574f4e69e87215f5bb871
Cr-Commit-Position: refs/heads/master@{#387525}

Powered by Google App Engine
This is Rietveld 408576698