CC Animation: Make LayerAnimationController to have just one value observer.

CC Animation: Make LayerAnimationController to have just one value observer.

- Erase ElementAnimations::ValueObserver
- Refactor active and pending observer notifications to that single observer.

LayerAnimationController will be merged to ElementAnimations in the dependent CL.

BUG=595571
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/032567ef1cded026eb25079f0e39c08f30fc852c
Cr-Commit-Position: refs/heads/master@{#387856}

[loyso (OOO), 2016-04-14 06:56:27]

Description was changed from

==========
CC Animation: Make LayerAnimationController to have just one value observer.

- Erase ElementAnimations::ValueObserver
- Refactor active and pending observer notifications to that single observer.

LayerAnimationController will be merged to ElementAnimations in the dependent
CL.

BUG=595571
==========

to

==========
CC Animation: Make LayerAnimationController to have just one value observer.

- Erase ElementAnimations::ValueObserver
- Refactor active and pending observer notifications to that single observer.

LayerAnimationController will be merged to ElementAnimations in the dependent
CL.

BUG=595571
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2016-04-14 06:57:07]

Description was changed from

==========
CC Animation: Make LayerAnimationController to have just one value observer.

- Erase ElementAnimations::ValueObserver
- Refactor active and pending observer notifications to that single observer.

LayerAnimationController will be merged to ElementAnimations in the dependent
CL.

BUG=595571
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animation: Make LayerAnimationController to have just one value observer.

- Erase ElementAnimations::ValueObserver
- Refactor active and pending observer notifications to that single observer.

LayerAnimationController will be merged to ElementAnimations in the dependent
CL.

BUG=595571
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2016-04-14 06:57:07]

loyso@chromium.org changed reviewers:
+ ajuma@chromium.org, vollick@chromium.org

[ajuma, 2016-04-14 14:01:18]

https://codereview.chromium.org/1882733005/diff/1/cc/animation/layer_animatio...
File cc/animation/layer_animation_controller.h (right):

https://codereview.chromium.org/1882733005/diff/1/cc/animation/layer_animatio...
cc/animation/layer_animation_controller.h:104: void
SetValueObserver(LayerAnimationValueObserver* observer) {
Nit: set_value_observer

https://codereview.chromium.org/1882733005/diff/1/cc/animation/layer_animatio...
cc/animation/layer_animation_controller.h:115: void
SetNeedsActiveValueObservations(bool needs_active_value_observations) {
set_needs_active_value_observations

https://codereview.chromium.org/1882733005/diff/1/cc/animation/layer_animatio...
cc/animation/layer_animation_controller.h:118: void
SetNeedsPendingValueObservations(bool needs_pending_value_observations) {
set_needs_pending_value_observations

https://codereview.chromium.org/1882733005/diff/1/cc/test/animation_test_comm...
File cc/test/animation_test_common.h (right):

https://codereview.chromium.org/1882733005/diff/1/cc/test/animation_test_comm...
cc/test/animation_test_common.h:116: class FakeTypedLayerAnimationValueObserver
Instead of having two fake observers types, can we always just use this one (and
rename it FakeLayerAnimationValueObserver)? The non-typed version seems
confusing (since it ignores tree_type).

[loyso (OOO), 2016-04-15 03:32:21]

https://codereview.chromium.org/1882733005/diff/1/cc/animation/layer_animatio...
File cc/animation/layer_animation_controller.h (right):

https://codereview.chromium.org/1882733005/diff/1/cc/animation/layer_animatio...
cc/animation/layer_animation_controller.h:104: void
SetValueObserver(LayerAnimationValueObserver* observer) {
On 2016/04/14 14:01:18, ajuma wrote:
> Nit: set_value_observer
I can make it out-of-line to comply with the naming (instead of renaming).

The observer (and any observations-related stuff) will go away in next couple of
CLs. I would like to save some time. I'll do the renaming if you insist.

https://codereview.chromium.org/1882733005/diff/1/cc/test/animation_test_comm...
File cc/test/animation_test_common.h (right):

https://codereview.chromium.org/1882733005/diff/1/cc/test/animation_test_comm...
cc/test/animation_test_common.h:116: class FakeTypedLayerAnimationValueObserver
On 2016/04/14 14:01:18, ajuma wrote:
> Instead of having two fake observers types, can we always just use this one
(and
> rename it FakeLayerAnimationValueObserver)? The non-typed version seems
> confusing (since it ignores tree_type).
The observer (and any observations-related stuff) will go away in next couple of
CLs. I just wanted to save some time and "cut-the-corner". Having just one time
requires more conversion of exisitng tests.
I'll do it if you insist.

[loyso (OOO), 2016-04-15 03:33:34]

On 2016/04/15 03:32:21, loyso wrote:
>
https://codereview.chromium.org/1882733005/diff/1/cc/animation/layer_animatio...
> File cc/animation/layer_animation_controller.h (right):
> 
>
https://codereview.chromium.org/1882733005/diff/1/cc/animation/layer_animatio...
> cc/animation/layer_animation_controller.h:104: void
> SetValueObserver(LayerAnimationValueObserver* observer) {
> On 2016/04/14 14:01:18, ajuma wrote:
> > Nit: set_value_observer
> I can make it out-of-line to comply with the naming (instead of renaming).
> 
> The observer (and any observations-related stuff) will go away in next couple
of
> CLs. I would like to save some time. I'll do the renaming if you insist.
> 
>
https://codereview.chromium.org/1882733005/diff/1/cc/test/animation_test_comm...
> File cc/test/animation_test_common.h (right):
> 
>
https://codereview.chromium.org/1882733005/diff/1/cc/test/animation_test_comm...
> cc/test/animation_test_common.h:116: class
FakeTypedLayerAnimationValueObserver
> On 2016/04/14 14:01:18, ajuma wrote:
> > Instead of having two fake observers types, can we always just use this one
> (and
> > rename it FakeLayerAnimationValueObserver)? The non-typed version seems
> > confusing (since it ignores tree_type).
> The observer (and any observations-related stuff) will go away in next couple
of
> CLs. I just wanted to save some time and "cut-the-corner". Having just one
time
> requires more conversion of exisitng tests.
> I'll do it if you insist.

* Having just one FakeLayerAnimationValueObserver requires more conversion of
exisitng tests.

[loyso (OOO), 2016-04-15 03:53:27]

Nevertheless, done. It was fast :)

https://codereview.chromium.org/1882733005/diff/1/cc/animation/layer_animatio...
File cc/animation/layer_animation_controller.h (right):

https://codereview.chromium.org/1882733005/diff/1/cc/animation/layer_animatio...
cc/animation/layer_animation_controller.h:104: void
SetValueObserver(LayerAnimationValueObserver* observer) {
On 2016/04/14 14:01:18, ajuma wrote:
> Nit: set_value_observer

Done.

https://codereview.chromium.org/1882733005/diff/1/cc/animation/layer_animatio...
cc/animation/layer_animation_controller.h:115: void
SetNeedsActiveValueObservations(bool needs_active_value_observations) {
On 2016/04/14 14:01:17, ajuma wrote:
> set_needs_active_value_observations

Done.

https://codereview.chromium.org/1882733005/diff/1/cc/animation/layer_animatio...
cc/animation/layer_animation_controller.h:118: void
SetNeedsPendingValueObservations(bool needs_pending_value_observations) {
On 2016/04/14 14:01:17, ajuma wrote:
> set_needs_pending_value_observations

Done.

https://codereview.chromium.org/1882733005/diff/1/cc/test/animation_test_comm...
File cc/test/animation_test_common.h (right):

https://codereview.chromium.org/1882733005/diff/1/cc/test/animation_test_comm...
cc/test/animation_test_common.h:116: class FakeTypedLayerAnimationValueObserver
On 2016/04/14 14:01:18, ajuma wrote:
> Instead of having two fake observers types, can we always just use this one
(and
> rename it FakeLayerAnimationValueObserver)? The non-typed version seems
> confusing (since it ignores tree_type).

Done.

[ajuma, 2016-04-15 12:08:00]

Thanks! lgtm

[loyso (OOO), 2016-04-18 02:31:14]

The CQ bit was checked by loyso@chromium.org

[commit-bot: I haz the power, 2016-04-18 02:31:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882733005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882733005/20001

[commit-bot: I haz the power, 2016-04-18 03:27:38]

Description was changed from

==========
CC Animation: Make LayerAnimationController to have just one value observer.

- Erase ElementAnimations::ValueObserver
- Refactor active and pending observer notifications to that single observer.

LayerAnimationController will be merged to ElementAnimations in the dependent
CL.

BUG=595571
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animation: Make LayerAnimationController to have just one value observer.

- Erase ElementAnimations::ValueObserver
- Refactor active and pending observer notifications to that single observer.

LayerAnimationController will be merged to ElementAnimations in the dependent
CL.

BUG=595571
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-04-18 03:27:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-18 03:29:19]

Description was changed from

==========
CC Animation: Make LayerAnimationController to have just one value observer.

- Erase ElementAnimations::ValueObserver
- Refactor active and pending observer notifications to that single observer.

LayerAnimationController will be merged to ElementAnimations in the dependent
CL.

BUG=595571
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animation: Make LayerAnimationController to have just one value observer.

- Erase ElementAnimations::ValueObserver
- Refactor active and pending observer notifications to that single observer.

LayerAnimationController will be merged to ElementAnimations in the dependent
CL.

BUG=595571
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/032567ef1cded026eb25079f0e39c08f30fc852c
Cr-Commit-Position: refs/heads/master@{#387856}
==========

[commit-bot: I haz the power, 2016-04-18 03:29:20]

Patchset 2 (id:??) landed as
https://crrev.com/032567ef1cded026eb25079f0e39c08f30fc852c
Cr-Commit-Position: refs/heads/master@{#387856}