Add plumbing to command buffer for CALayer min and mag filter.

Add plumbing to command buffer for CALayer min and mag filter.

This CL has no intended behavior change.

BUG=602103
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/e028bfb3fb300437b56f0b377e4bd9f922d8df04
Cr-Commit-Position: refs/heads/master@{#388257}

[erikchen, 2016-04-13 01:36:53]

Description was changed from

==========
Plumbing for min/mag filter..

BUG=
==========

to

==========
Plumbing for min/mag filter..

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-04-13 01:36:53]

Description was changed from

==========
Plumbing for min/mag filter..

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Plumbing for min/mag filter..

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[erikchen, 2016-04-13 01:37:03]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 01:37:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1887533002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1887533002/1

[commit-bot: I haz the power, 2016-04-13 02:04:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 02:04:42]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[erikchen, 2016-04-13 17:19:48]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2016-04-13 17:20:04]

Description was changed from

==========
Plumbing for min/mag filter..

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Plumbing for min/mag filter..

BUG=602103
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-04-13 17:20:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1887533002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1887533002/20001

[erikchen, 2016-04-13 17:20:48]

Description was changed from

==========
Plumbing for min/mag filter..

BUG=602103
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Add plumbing to command buffer for CALayer min and mag filter.

This CL has no intended behavior change.

BUG=602103
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[erikchen, 2016-04-13 17:21:04]

Description was changed from

==========
Add plumbing to command buffer for CALayer min and mag filter.

This CL has no intended behavior change.

BUG=602103
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Add plumbing to command buffer for CALayer min and mag filter.

This CL has no intended behavior change.

BUG=602103
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[erikchen, 2016-04-13 17:21:17]

erikchen@chromium.org changed reviewers:
+ ccameron@chromium.org

[erikchen, 2016-04-13 17:21:18]

ccameron: Please review.

[commit-bot: I haz the power, 2016-04-13 18:32:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 18:32:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-04-13 19:07:59]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 19:08:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1887533002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1887533002/20001

[ccameron, 2016-04-13 19:32:28]

lgtm.

At some point soon we should start looking into moving the CALayerTree into the
browser process (so we can skip all of this plumbing).

https://codereview.chromium.org/1887533002/diff/20001/gpu/GLES2/gl2extchromium.h
File gpu/GLES2/gl2extchromium.h (right):

https://codereview.chromium.org/1887533002/diff/20001/gpu/GLES2/gl2extchromiu...
gpu/GLES2/gl2extchromium.h:803: 
extra line?

[erikchen, 2016-04-13 19:43:12]

erikchen@chromium.org changed reviewers:
+ piman@chromium.org, yzshen@chromium.org

[erikchen, 2016-04-13 19:43:12]

yzshen: Please review mojo/public
piman: Please review gpu/ and mojo/gpu/

https://codereview.chromium.org/1887533002/diff/20001/gpu/GLES2/gl2extchromium.h
File gpu/GLES2/gl2extchromium.h (right):

https://codereview.chromium.org/1887533002/diff/20001/gpu/GLES2/gl2extchromiu...
gpu/GLES2/gl2extchromium.h:803: 
On 2016/04/13 19:32:27, ccameron wrote:
> extra line?

Done.

[piman, 2016-04-14 03:00:34]

https://codereview.chromium.org/1887533002/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/1887533002/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:9889: c.sorting_context_id,
c.filter)) {
How do we validate c.filter for correct values? Are these GL filters?
Note, for the validation, make sure you read c.filter only once - it's in shared
memory and an untrusted client could race for changing it after you validated
it.

[yzshen1, 2016-04-14 16:12:42]

lgtm

[erikchen, 2016-04-14 17:23:19]

piman: PTAL

https://codereview.chromium.org/1887533002/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/1887533002/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:9889: c.sorting_context_id,
c.filter)) {
On 2016/04/14 03:00:34, piman wrote:
> How do we validate c.filter for correct values? Are these GL filters?
> Note, for the validation, make sure you read c.filter only once - it's in
shared
> memory and an untrusted client could race for changing it after you validated
> it.

I added validation logic. I updated the documentation to list the valid values.

[erikchen, 2016-04-14 17:23:29]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 17:23:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1887533002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1887533002/60001

[commit-bot: I haz the power, 2016-04-14 18:30:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 18:30:31]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[piman, 2016-04-14 18:55:13]

lgtm

[erikchen, 2016-04-16 00:57:14]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-04-16 00:57:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org, yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/1887533002/#ps60001
(title: "Comments from piman.")

[commit-bot: I haz the power, 2016-04-16 00:57:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1887533002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1887533002/60001

[commit-bot: I haz the power, 2016-04-16 02:27:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-16 02:27:58]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-04-18 17:15:32]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-04-18 17:16:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1887533002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1887533002/60001

[erikchen, 2016-04-18 17:27:20]

The CQ bit was unchecked by erikchen@chromium.org

[erikchen, 2016-04-18 17:31:31]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-04-18 17:31:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org, yzshen@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1887533002/#ps80001
(title: "Default filter must be GL_LINEAR.")

[commit-bot: I haz the power, 2016-04-18 17:32:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1887533002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1887533002/80001

[commit-bot: I haz the power, 2016-04-18 19:10:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 19:10:46]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-04-19 17:40:41]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-04-19 17:40:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org, yzshen@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1887533002/#ps100001
(title: "Fix parameter ordering.")

[commit-bot: I haz the power, 2016-04-19 17:40:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1887533002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1887533002/100001

[commit-bot: I haz the power, 2016-04-19 18:48:08]

Description was changed from

==========
Add plumbing to command buffer for CALayer min and mag filter.

This CL has no intended behavior change.

BUG=602103
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Add plumbing to command buffer for CALayer min and mag filter.

This CL has no intended behavior change.

BUG=602103
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-04-19 18:48:09]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-22 19:14:15]

Description was changed from

==========
Add plumbing to command buffer for CALayer min and mag filter.

This CL has no intended behavior change.

BUG=602103
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Add plumbing to command buffer for CALayer min and mag filter.

This CL has no intended behavior change.

BUG=602103
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/e028bfb3fb300437b56f0b377e4bd9f922d8df04
Cr-Commit-Position: refs/heads/master@{#388257}
==========

[commit-bot: I haz the power, 2016-04-22 19:14:16]

Patchset 6 (id:??) landed as
https://crrev.com/e028bfb3fb300437b56f0b377e4bd9f922d8df04
Cr-Commit-Position: refs/heads/master@{#388257}