Hook up plumbing for minification/magnification filters.

Hook up plumbing for minification/magnification filters.

BUG=602103
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/d152a667968f06bd8cd13aa8e8b761368660f48e
Cr-Commit-Position: refs/heads/master@{#390278}

[erikchen, 2016-04-19 20:52:38]

Description was changed from

==========
Hook up plumbing for minification/magnification filters.

BUG=602103
==========

to

==========
Hook up plumbing for minification/magnification filters.

BUG=602103
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-04-19 20:52:38]

Description was changed from

==========
Hook up plumbing for minification/magnification filters.

BUG=602103
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Hook up plumbing for minification/magnification filters.

BUG=602103
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[erikchen, 2016-04-19 20:53:41]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 20:53:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893273005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893273005/1

[commit-bot: I haz the power, 2016-04-19 21:09:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 21:09:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[erikchen, 2016-04-19 22:19:50]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 22:20:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893273005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893273005/20001

[commit-bot: I haz the power, 2016-04-19 22:34:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 22:34:55]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[erikchen, 2016-04-26 00:45:59]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 00:46:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893273005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893273005/60001

[commit-bot: I haz the power, 2016-04-26 01:04:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 01:04:16]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[erikchen, 2016-04-27 17:54:19]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 17:54:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893273005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893273005/80001

[commit-bot: I haz the power, 2016-04-27 17:58:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 17:58:03]

Dry run: Try jobs failed on following builders:
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-04-27 21:30:13]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 21:30:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893273005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893273005/100001

[commit-bot: I haz the power, 2016-04-27 22:30:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 22:30:32]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-04-27 22:37:33]

erikchen@chromium.org changed reviewers:
+ ccameron@chromium.org

[erikchen, 2016-04-27 22:37:34]

ccameron: Please review.

[ccameron, 2016-04-27 22:45:48]

lgtm, though I'd prefer to use raw pointers for the NSString bit.

https://codereview.chromium.org/1893273005/diff/100001/ui/accelerated_widget_...
File ui/accelerated_widget_mac/ca_renderer_layer_tree.h (right):

https://codereview.chromium.org/1893273005/diff/100001/ui/accelerated_widget_...
ui/accelerated_widget_mac/ca_renderer_layer_tree.h:204:
base::scoped_nsobject<NSString> ca_filter;
I'd be inclined to leave this just as NSString* const instead of doing all of
this alloc/free.

https://codereview.chromium.org/1893273005/diff/100001/ui/accelerated_widget_...
File ui/accelerated_widget_mac/ca_renderer_layer_tree.mm (right):

https://codereview.chromium.org/1893273005/diff/100001/ui/accelerated_widget_...
ui/accelerated_widget_mac/ca_renderer_layer_tree.mm:350:
ca_filter(std::move(layer.ca_filter)),
Cause then we don't have to do the move here.

https://codereview.chromium.org/1893273005/diff/100001/ui/accelerated_widget_...
ui/accelerated_widget_mac/ca_renderer_layer_tree.mm:589: update_ca_filter =
![old_layer->ca_filter isEqualToString:ca_filter];
And we can just do a ptr compare.

[erikchen, 2016-04-28 01:18:21]

https://codereview.chromium.org/1893273005/diff/100001/ui/accelerated_widget_...
File ui/accelerated_widget_mac/ca_renderer_layer_tree.h (right):

https://codereview.chromium.org/1893273005/diff/100001/ui/accelerated_widget_...
ui/accelerated_widget_mac/ca_renderer_layer_tree.h:204:
base::scoped_nsobject<NSString> ca_filter;
On 2016/04/27 22:45:48, ccameron wrote:
> I'd be inclined to leave this just as NSString* const instead of doing all of
> this alloc/free.

Done.

https://codereview.chromium.org/1893273005/diff/100001/ui/accelerated_widget_...
File ui/accelerated_widget_mac/ca_renderer_layer_tree.mm (right):

https://codereview.chromium.org/1893273005/diff/100001/ui/accelerated_widget_...
ui/accelerated_widget_mac/ca_renderer_layer_tree.mm:350:
ca_filter(std::move(layer.ca_filter)),
On 2016/04/27 22:45:48, ccameron wrote:
> Cause then we don't have to do the move here.

Done.

https://codereview.chromium.org/1893273005/diff/100001/ui/accelerated_widget_...
ui/accelerated_widget_mac/ca_renderer_layer_tree.mm:589: update_ca_filter =
![old_layer->ca_filter isEqualToString:ca_filter];
On 2016/04/27 22:45:48, ccameron wrote:
> And we can just do a ptr compare.

Done.

[erikchen, 2016-04-28 01:18:26]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-04-28 01:18:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/1893273005/#ps140001
(title: "Fix test.")

[commit-bot: I haz the power, 2016-04-28 01:18:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893273005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893273005/140001

[commit-bot: I haz the power, 2016-04-28 02:25:42]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-04-30 17:15:39]

Patchset 8 (id:??) landed as
https://crrev.com/d152a667968f06bd8cd13aa8e8b761368660f48e
Cr-Commit-Position: refs/heads/master@{#390278}

[commit-bot: I haz the power, 2016-04-30 17:53:49]

Description was changed from

==========
Hook up plumbing for minification/magnification filters.

BUG=602103
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Hook up plumbing for minification/magnification filters.

BUG=602103
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/d152a667968f06bd8cd13aa8e8b761368660f48e
Cr-Commit-Position: refs/heads/master@{#390278}
==========