Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1886673002: [Findit] Differentiate compile failures and test failures. (Closed)

Created:
4 years, 8 months ago by stgao
Modified:
4 years, 8 months ago
Reviewers:
chanli, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Differentiate compile failures and test failures. This is a preparation to have separate UI and pipeline for compile and tests failures. BUG=596971 Committed: https://chromium.googlesource.com/infra/infra/+/d0335aa60558c793363de143dec8932d5a61b59d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -43 lines) Patch
M appengine/findit/common/constants.py View 1 chunk +2 lines, -1 line 0 comments Download
A + appengine/findit/common/waterfall/failure_type.py View 1 chunk +5 lines, -0 lines 0 comments Download
M appengine/findit/model/test/wf_analysis_test.py View 2 chunks +27 lines, -0 lines 0 comments Download
M appengine/findit/model/wf_analysis.py View 2 chunks +27 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/detect_first_failure_pipeline.py View 5 chunks +20 lines, -5 lines 0 comments Download
M appengine/findit/waterfall/test/data/m_b_221.json View 1 chunk +1 line, -8 lines 0 comments Download
M appengine/findit/waterfall/test/data/m_b_222.json View 1 chunk +1 line, -8 lines 0 comments Download
M appengine/findit/waterfall/test/data/m_b_223.json View 1 chunk +1 line, -8 lines 0 comments Download
M appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py View 6 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
stgao
4 years, 8 months ago (2016-04-13 06:02:54 UTC) #2
lijeffrey
lgtm
4 years, 8 months ago (2016-04-14 19:49:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886673002/1
4 years, 8 months ago (2016-04-14 20:13:28 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 20:17:28 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/d0335aa60558c793363de143dec89...

Powered by Google App Engine
This is Rietveld 408576698