[Findit] Differentiate compile failures and test failures.

appengine/findit/model/wf_analysis.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from google.appengine.ext import ndb
 
+from common import constants
+from common.waterfall import failure_type
 from model.base_build_model import BaseBuildModel
 from model import analysis_status
 from model import result_status
 
 
 class WfAnalysis(BaseBuildModel):
   """Represents an analysis of a build of a builder in a Chromium waterfall.
 
   'Wf' is short for waterfall.
   """
@@ skipping 64 matching lines @@
     return None
 
   def Reset(self):  # pragma: no cover
     """Resets to the state as if no analysis is run."""
     self.pipeline_status_path = None
     self.status = analysis_status.PENDING
     self.request_time = None
     self.start_time = None
     self.end_time = None
 
+  @property
+  def failure_type(self):
+    if self.build_failure_type is not None:
+      return self.build_failure_type
+
+    # Legacy data don't have property ``build_failure_type``.
+    if not self.result:
+      return failure_type.UNKNOWN
+
+    step_failures = self.result.get('failures', [])
+    if not step_failures:
+      return failure_type.UNKNOWN
+
+    for step_result in step_failures:
+      if step_result['step_name'] == constants.COMPILE_STEP_NAME:
+        return failure_type.COMPILE
+
+    # Although the failed steps could be infra setup steps like "bot_update",
+    # for legacy data we just assume all of them are tests if not compile.
+    return failure_type.TEST
+
   # When the build cycle started.
   build_start_time = ndb.DateTimeProperty(indexed=True)
+  # Whether the build cycle has completed.
   build_completed = ndb.BooleanProperty(indexed=False)
+  # Whether it is a compile failure, test failure, infra failure or others.
+  # Refer to common/waterfall/failure_type.py for all the failure types.
+  build_failure_type = ndb.IntegerProperty(indexed=False)
 
   # The url path to the pipeline status page.
   pipeline_status_path = ndb.StringProperty(indexed=False)
   # The status of the analysis.
   status = ndb.IntegerProperty(
       default=analysis_status.PENDING, indexed=False)
   # When the analysis was requested.
   request_time = ndb.DateTimeProperty(indexed=False)
   # When the analysis actually started.
   start_time = ndb.DateTimeProperty(indexed=False)
@@ skipping 11 matching lines @@
   suspected_cls = ndb.JsonProperty(indexed=False, compressed=True)
   # Record the id of try job results of each failure.
   failure_result_map = ndb.JsonProperty(indexed=False, compressed=True)
 
   # The actual culprit CLs that are responsible for the failures.
   culprit_cls = ndb.JsonProperty(indexed=False, compressed=True)
   # Conclusion of analysis result for the build failure: 'Found' or 'Not Found'.
   result_status = ndb.IntegerProperty(indexed=True)
   # Record the history of triage.
   triage_history = ndb.JsonProperty(indexed=False, compressed=True)