[Findit] Differentiate compile failures and test failures.

appengine/findit/model/test/wf_analysis_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from datetime import datetime
 
 import unittest
 
+from common.waterfall import failure_type
 from model.wf_analysis import WfAnalysis
 from model import analysis_status
 from model import result_status
 
 
 class WfAnalysisTest(unittest.TestCase):
   def testWfAnalysisStatusIsCompleted(self):
     for status in (analysis_status.COMPLETED, analysis_status.ERROR):
       analysis = WfAnalysis.Create('m', 'b', 123)
       analysis.status = status
@@ skipping 86 matching lines @@
 
   def testWfAnalysisHasIncorrectResult(self):
     for status in (
         result_status.FOUND_INCORRECT,
         result_status.NOT_FOUND_INCORRECT,
         result_status.FOUND_INCORRECT_DUPLICATE):
       analysis = WfAnalysis.Create('m', 'b', 123)
       analysis.status = analysis_status.COMPLETED
       analysis.result_status = status
       self.assertFalse(analysis.correct)
+
+  def testFailureTypeForNoneLegacyData(self):
+    analysis = WfAnalysis.Create('m', 'b', 123)
+    analysis.build_failure_type = failure_type.COMPILE
+    analysis.result = None
+    self.assertEqual(failure_type.COMPILE, analysis.failure_type)
+
+  def testFailureTypeForLegacyDataWithoutResult(self):
+    analysis = WfAnalysis.Create('m', 'b', 123)
+    analysis.result = None
+    self.assertEqual(failure_type.UNKNOWN, analysis.failure_type)
+
+  def testFailureTypeForLegacyDataWithoutFailedSteps(self):
+    analysis = WfAnalysis.Create('m', 'b', 123)
+    analysis.result = {'failures': []}
+    self.assertEqual(failure_type.UNKNOWN, analysis.failure_type)
+
+  def testFailureTypeForLegacyDataWithFailedCompileStep(self):
+    analysis = WfAnalysis.Create('m', 'b', 123)
+    analysis.result = {'failures': [{'step_name': 'compile'}]}
+    self.assertEqual(failure_type.COMPILE, analysis.failure_type)
+
+  def testFailureTypeForLegacyDataWithFailedTestStep(self):
+    analysis = WfAnalysis.Create('m', 'b', 123)
+    analysis.result = {'failures': [{'step_name': 'browser_tests'}]}
+    self.assertEqual(failure_type.TEST, analysis.failure_type)