[Findit] Differentiate compile failures and test failures.

appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import json
 import os
 import urllib
 import zlib
 
@@ skipping 242 matching lines @@
         'sort': 'created_ts'
     }
     cursor_url = ('%s&cursor=thisisacursor') % url
 
     self.mocked_urlfetch.register_handler(url, response)
     self.mocked_urlfetch.register_handler(
         cursor_url, json.dumps(cursor_swarming_data))
 
   def _MockUrlfetchWithIsolatedData(
       self, isolated_data=None, file_url=None,
-      file_name=None, build_number=None):  # pragma: no cover
+      file_name=None, build_number=None):
     if isolated_data:  # Mocks POST requests to isolated server.
       url = '%s/_ah/api/isolateservice/v1/retrieve' % (
           isolated_data['isolatedserver'])
       post_data = {
           'digest': isolated_data['digest'],
           'namespace': isolated_data['namespace']
       }
       file_name = isolated_data['digest']
-      if build_number:
+      if build_number:  # pragma: no branch
         file_name = isolated_data['digest'][:-4]
       content = self._GetSwarmingData('isolated', file_name, build_number)
 
-    elif file_url and file_name:  # Mocks GET requests to isolated server.
+    elif file_url and file_name:  # pragma: no branch.
+      # Mocks GET requests to isolated server.
       url = file_url
       post_data = None
       content = self._GetSwarmingData('isolated', file_name)
 
     self.mocked_urlfetch.register_handler(
         url, content,
         data=(json.dumps(post_data, sort_keys=True, separators=(',', ':'))
               if post_data else None))
 
   def testAnalyzeSwarmingTestResultsInitiateLastPassForTests(self):
@@ skipping 278 matching lines @@
     master_name = 'm'
     builder_name = 'b'
     build_number = 223
 
     self._CreateAndSaveWfAnanlysis(
         master_name, builder_name, build_number, analysis_status.RUNNING)
 
     # Mock data for retrieving data from swarming server for a build.
     self._MockUrlFetchWithSwarmingData(master_name, builder_name, 223)
 
-    for n in xrange(223, 219, -1):  # pragma: no cover
+    for n in xrange(223, 219, -1):  # pragma: no branch.
       # Setup build data for builds:
       self._MockUrlfetchWithBuildData(master_name, builder_name, n)
       if n == 220:
         break
 
       # Mock data for retrieving data from swarming server for a single step.
       self._MockUrlFetchWithSwarmingData(
           master_name, builder_name, n, 'abc_test')
 
       # Mock data for retrieving hash to output.json from isolated server.
       isolated_data = {
           'isolatedserver': 'https://isolateserver.appspot.com',
           'namespace': {
               'namespace': 'default-gzip'
           },
           'digest': 'isolatedhashabctest-%d' % n
       }
-      self._MockUrlfetchWithIsolatedData(
-          isolated_data, build_number=n)
+      self._MockUrlfetchWithIsolatedData(isolated_data, build_number=n)
       # Mock data for retrieving url to output.json from isolated server.
       file_hash_data = {
           'isolatedserver': 'https://isolateserver.appspot.com',
           'namespace': {
               'namespace': 'default-gzip'
           },
           'digest': 'abctestoutputjsonhash-%d' % n
       }
-      self._MockUrlfetchWithIsolatedData(
-          file_hash_data, build_number=n)
+      self._MockUrlfetchWithIsolatedData(file_hash_data, build_number=n)
 
       # Mock data for downloading output.json from isolated server.
       self._MockUrlfetchWithIsolatedData(
           None,
           ('https://isolateserver.storage.googleapis.com/default-gzip/'
            'm_b_%d_abc_test' % n),
           '%s_%s_%d_%s.json' % (master_name, builder_name, n, 'abc_test'))
 
     step_221 = WfStep.Create(master_name, builder_name, 221, 'abc_test')
     step_221.isolated = True
     step_221.log_data = (
         '{"Unittest3.Subtest3": "YS9iL3UzczIuY2M6MTEwOiBGYWlsdXJlCg=="}')
     step_221.put()
 
     pipeline = DetectFirstFailurePipeline()
     failure_info = pipeline.run(master_name, builder_name, build_number)
 
     expected_failed_steps = {
-        'compile': {
-            'current_failure': 223,
-            'first_failure': 221,
-            'last_pass': 220
-        },
         'abc_test': {
             'current_failure': 223,
             'first_failure': 222,
             'last_pass': 221,
             'list_isolated_data': [
                 {
                     'isolatedserver': 'https://isolateserver.appspot.com',
                     'namespace': 'default-gzip',
                     'digest': 'isolatedhashabctest-223'
                 }
@@ skipping 27 matching lines @@
         221: '{"Unittest3.Subtest3": "YS9iL3UzczIuY2M6MTEwOiBGYWlsdXJlCg=="}'
     }
 
     for n in xrange(223, 220, -1):
       step = WfStep.Get(master_name, builder_name, n, 'abc_test')
       self.assertIsNotNone(step)
       self.assertTrue(step.isolated)
       self.assertEqual(expected_step_log_data[n], step.log_data)
 
     self.assertEqual(expected_failed_steps, failure_info['failed_steps'])