Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1886613003: Remove GrTextureStorageAllocator. This was added from Chromium but never used and not expected to b… (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove GrTextureStorageAllocator. This was added from Chromium but never used and not expected to be used. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1886613003 Committed: https://skia.googlesource.com/skia/+/7e68ab73186ab02a6030d3959e7372f983f85af5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -250 lines) Patch
M include/core/SkSurface.h View 2 chunks +2 lines, -7 lines 0 comments Download
M include/gpu/GrTypes.h View 2 chunks +0 lines, -59 lines 0 comments Download
M src/gpu/GrTexture.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrTextureProvider.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 4 chunks +5 lines, -10 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 3 chunks +1 line, -39 lines 0 comments Download
M src/gpu/gl/GrGLTexture.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M src/image/SkSurface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
D tests/TextureStorageAllocator.cpp View 1 chunk +0 lines, -111 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
bsalomon
4 years, 8 months ago (2016-04-13 20:41:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886613003/1
4 years, 8 months ago (2016-04-13 20:41:26 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 8 months ago (2016-04-13 20:41:28 UTC) #6
robertphillips
lgtm
4 years, 8 months ago (2016-04-13 21:28:51 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 21:29:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7e68ab73186ab02a6030d3959e7372f983f85af5

Powered by Google App Engine
This is Rietveld 408576698