Subzero. ARM32. Implements vector select.

Subzero. ARM32. Implements vector select.

Also piggy-backs necro-comments from cl 1878943009.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4076
R=kschimpf@google.com

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=397f602c4e4e5697806bf74e37a651ab78680628

[John, 2016-04-14 21:40:44]

jpp@chromium.org changed reviewers:
+ eholk@chromium.org, kschimpf@chromium.org, sehr@chromium.org,
stichnot@chromium.org

[John, 2016-04-14 21:40:45]

presubmit happy.

[Karl, 2016-04-14 22:02:02]

kschimpf@google.com changed reviewers:
+ kschimpf@google.com

[Karl, 2016-04-14 22:02:03]

Otherwise LGTM.

Did not see anything wrong with the target lowering changes, but I'm not sure
that is enough to give unconditional LGTM.

https://codereview.chromium.org/1886263004/diff/40001/src/IceAssemblerARM32.h
File src/IceAssemblerARM32.h (right):

https://codereview.chromium.org/1886263004/diff/40001/src/IceAssemblerARM32.h...
src/IceAssemblerARM32.h:346: void vbslq(const Operand *OpQd, const Operand
*OpQm, const Operand *OpQn);
When adding a method that isn't in Dart, update comment at end of
DartARM32/assember_arm.h, so it's documented that this was needed, but not in
Dart.

[John, 2016-04-14 22:09:00]

https://codereview.chromium.org/1886263004/diff/40001/src/IceAssemblerARM32.h
File src/IceAssemblerARM32.h (right):

https://codereview.chromium.org/1886263004/diff/40001/src/IceAssemblerARM32.h...
src/IceAssemblerARM32.h:346: void vbslq(const Operand *OpQd, const Operand
*OpQm, const Operand *OpQn);
On 2016/04/14 22:02:02, Karl wrote:
> When adding a method that isn't in Dart, update comment at end of
> DartARM32/assember_arm.h, so it's documented that this was needed, but not in
> Dart.

I totally forgot about updating that file. I also added the instructions I
previously added to the assembler.

[John, 2016-04-15 13:27:01]

Description was changed from

==========
Subzero. ARM32. Implements vector select.

Also piggy-backs necro-comments from cl 1878943009.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4076
==========

to

==========
Subzero. ARM32. Implements vector select.

Also piggy-backs necro-comments from cl 1878943009.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4076
R=kschimpf@google.com

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[John, 2016-04-15 13:27:03]

Committed patchset #4 (id:60001) manually as
397f602c4e4e5697806bf74e37a651ab78680628 (presubmit successful).