src/DartARM32/assembler_arm.h - Issue 1886263004: Subzero. ARM32. Implements vector select.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/DartARM32/assembler_arm.h

Issue 1886263004: Subzero. ARM32. Implements vector select. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Addresses comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/DartARM32/assembler_arm.h

diff --git a/src/DartARM32/assembler_arm.h b/src/DartARM32/assembler_arm.h

index 4d205c780f824d87f58da1e686f4b96d0dbfa7e7..c6e53df42f1d59be9c9cc19ed27a49b35f2645b9 100644

--- a/src/DartARM32/assembler_arm.h

+++ b/src/DartARM32/assembler_arm.h

@@ -1406,9 +1406,13 @@ class Assembler : public ValueObject {

// ARM32::AssemblerARM32::uxt() (uxtb and uxth)

// ARM32::AssemblerARM32::vpop()

// ARM32::AssemblerARM32::vpush()

- // ARM32::AssemblerARM32:rbit()

+ // ARM32::AssemblerARM32::rbit()

+ // ARM32::AssemblerARM32::vbslq()

// ARM32::AssemblerARM32::veord()

// ARM32::AssemblerARM32::vld1qr()

+ // ARM32::AssemblerARM32::vshlqc

+ // ARM32::AssemblerARM32::vshrqic

+ // ARM32::AssemblerARM32::vshrquc

// ARM32::AssemblerARM32::vst1qr()

// ARM32::AssemblerARM32::vmorqi()

// ARM32::AssemblerARM32::vmovqc()

« no previous file with comments | « no previous file | src/IceAssemblerARM32.h » ('j') | no next file with comments »